Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(417)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/extensions/ExtensionPanel.js

Issue 2560553004: Revert of [DevTools] Remove methods on Common.Event. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 115 matching lines...) Expand 10 before | Expand all | Expand 10 after
126 * @param {!Extensions.ExtensionServer} server 126 * @param {!Extensions.ExtensionServer} server
127 * @param {string} id 127 * @param {string} id
128 * @param {string} iconURL 128 * @param {string} iconURL
129 * @param {string=} tooltip 129 * @param {string=} tooltip
130 * @param {boolean=} disabled 130 * @param {boolean=} disabled
131 */ 131 */
132 constructor(server, id, iconURL, tooltip, disabled) { 132 constructor(server, id, iconURL, tooltip, disabled) {
133 this._id = id; 133 this._id = id;
134 134
135 this._toolbarButton = new UI.ToolbarButton('', ''); 135 this._toolbarButton = new UI.ToolbarButton('', '');
136 this._toolbarButton.addEventListener( 136 this._toolbarButton.addEventListener('click', server.notifyButtonClicked.bin d(server, this._id));
137 UI.ToolbarButton.Events.Click, server.notifyButtonClicked.bind(server, t his._id));
138 this.update(iconURL, tooltip, disabled); 137 this.update(iconURL, tooltip, disabled);
139 } 138 }
140 139
141 /** 140 /**
142 * @param {string} iconURL 141 * @param {string} iconURL
143 * @param {string=} tooltip 142 * @param {string=} tooltip
144 * @param {boolean=} disabled 143 * @param {boolean=} disabled
145 */ 144 */
146 update(iconURL, tooltip, disabled) { 145 update(iconURL, tooltip, disabled) {
147 if (typeof iconURL === 'string') 146 if (typeof iconURL === 'string')
(...skipping 131 matching lines...) Expand 10 before | Expand all | Expand 10 after
279 this._objectPropertiesView.element.removeChildren(); 278 this._objectPropertiesView.element.removeChildren();
280 var section = new Components.ObjectPropertiesSection(object, title); 279 var section = new Components.ObjectPropertiesSection(object, title);
281 if (!title) 280 if (!title)
282 section.titleLessMode(); 281 section.titleLessMode();
283 section.expand(); 282 section.expand();
284 section.editable = false; 283 section.editable = false;
285 this._objectPropertiesView.element.appendChild(section.element); 284 this._objectPropertiesView.element.appendChild(section.element);
286 callback(); 285 callback();
287 } 286 }
288 }; 287 };
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698