Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 2560513002: Unify predicates for elements "contributing" to a <clipPath> (Closed)

Created:
4 years ago by fs
Modified:
4 years ago
CC:
fs, blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, krit, eae+blinkwatch, f(malita), gyuyoung2, jchaffraix+rendering, kouhei+svg_chromium.org, leviw+renderwatch, pdr+svgwatchlist_chromium.org, pdr+renderingwatchlist_chromium.org, rwlbuis, Stephen Chennney, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Unify predicates for elements "contributing" to a <clipPath> LayoutSVGResourceClipper has four loops that iterate the child elements that contribute to the clip path. They are however all subtly different. To remedy this and make it more obvious that the same set of elements are iterated, add a helper contributesToClip(...) that handles the checking of if an element is considered to be contributing to the clip path or not. This yields four loops with a very similar structure. Also move path-extraction to a helper, use helpers from Traversal<...> for basic iteration, drop LayoutObject/ComputedStyle related checks from the SVGUseElement helper (now handled elsewhere) and hoist the PaintInfo out of the loop in createContentPicture since it is invariant. Committed: https://crrev.com/9fa2375bf1a676c4bb8d6b7aa56ff70b30769819 Cr-Commit-Position: refs/heads/master@{#436703}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -108 lines) Patch
M third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceClipper.cpp View 6 chunks +85 lines, -101 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGUseElement.cpp View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
fs
4 years ago (2016-12-06 19:27:16 UTC) #6
Stephen Chennney
lgtm
4 years ago (2016-12-06 19:44:37 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2560513002/1
4 years ago (2016-12-06 20:07:39 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-06 20:40:55 UTC) #11
commit-bot: I haz the power
4 years ago (2016-12-06 20:43:40 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9fa2375bf1a676c4bb8d6b7aa56ff70b30769819
Cr-Commit-Position: refs/heads/master@{#436703}

Powered by Google App Engine
This is Rietveld 408576698