Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 2560503002: [ObjC ARC] Converts ios/chrome/browser/device_sharing:device_sharing to ARC.Automatically generat… (Closed)

Created:
4 years ago by stkhapugin
Modified:
4 years ago
CC:
chromium-reviews, pkl (ping after 24h if needed), sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ObjC ARC] Converts ios/chrome/browser/device_sharing:device_sharing to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Committed: https://crrev.com/dccb2e26346c079e52c21f4d699589417905c408 Cr-Commit-Position: refs/heads/master@{#436944}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M ios/chrome/browser/device_sharing/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/device_sharing/device_sharing_manager.mm View 2 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
stkhapugin
PTAL
4 years ago (2016-12-07 14:20:41 UTC) #6
noyau (Ping after 24h)
lgtm
4 years ago (2016-12-07 14:21:28 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2560503002/1
4 years ago (2016-12-07 14:21:41 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-07 14:25:50 UTC) #11
commit-bot: I haz the power
4 years ago (2016-12-07 14:29:18 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dccb2e26346c079e52c21f4d699589417905c408
Cr-Commit-Position: refs/heads/master@{#436944}

Powered by Google App Engine
This is Rietveld 408576698