Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2560473004:
Updating the CLD3 commit hash in DEPS (Closed)
|
Created:
4 years ago by Anton Bakalov Modified:
4 years ago CC:
chromium-reviews, djweiss1, riesa Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionUpdating the CLD3 commit hash in DEPS
The main changes are:
1) a retrained model with additional script-based features.
GitHub page showing the diff:
https://github.com/google/cld3/commit/fa5974a4d3b5e7934fcb166ff26ed6bfce68b18a
2) updating the feature spec parser to parse features without args.
GitHub page showing the diff:
https://github.com/google/cld3/commit/c03368eff92acc56756df2d4cd74a01a674409ea
BUG=672185
Committed: https://crrev.com/3382ba03f380d3f681a84c8c8bf83bebf9ca2b7c
Cr-Commit-Position: refs/heads/master@{#437081}
Patch Set 1 #Messages
Total messages: 18 (11 generated)
The CQ bit was checked by abakalov@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Updating the CLD3 commit hash in DEPS BUG= ========== to ========== Updating the CLD3 commit hash in DEPS The main change are: 1) a retrained model with additional script-based features. GitHub page showing the diff: https://github.com/google/cld3/commit/fa5974a4d3b5e7934fcb166ff26ed6bfce68b18a 2) updating the feature spec parser to parse features without args. GitHub page showing the diff: https://github.com/google/cld3/commit/c03368eff92acc56756df2d4cd74a01a674409ea BUG= ==========
abakalov@chromium.org changed reviewers: + groby@chromium.org, rouslan@chromium.org
Hi Rachel and Rouslan, The earlier issue is now resolved. We were able to reproduce the error with the bot win_chromium_dbg_ng which is now green. Thanks in advance for the review! Anton
lgtm
Description was changed from ========== Updating the CLD3 commit hash in DEPS The main change are: 1) a retrained model with additional script-based features. GitHub page showing the diff: https://github.com/google/cld3/commit/fa5974a4d3b5e7934fcb166ff26ed6bfce68b18a 2) updating the feature spec parser to parse features without args. GitHub page showing the diff: https://github.com/google/cld3/commit/c03368eff92acc56756df2d4cd74a01a674409ea BUG= ========== to ========== Updating the CLD3 commit hash in DEPS The main changes are: 1) a retrained model with additional script-based features. GitHub page showing the diff: https://github.com/google/cld3/commit/fa5974a4d3b5e7934fcb166ff26ed6bfce68b18a 2) updating the feature spec parser to parse features without args. GitHub page showing the diff: https://github.com/google/cld3/commit/c03368eff92acc56756df2d4cd74a01a674409ea BUG=672185 ==========
RS LGTM
Thanks for the reviews!
The CQ bit was checked by abakalov@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1481148367878250, "parent_rev":
"0a1033e39678199223556ff5248fdffe790524cb", "commit_rev":
"bce5ea43ee2824fd24557dcfe49bffd910144fb0"}
Message was sent while issue was closed.
Description was changed from ========== Updating the CLD3 commit hash in DEPS The main changes are: 1) a retrained model with additional script-based features. GitHub page showing the diff: https://github.com/google/cld3/commit/fa5974a4d3b5e7934fcb166ff26ed6bfce68b18a 2) updating the feature spec parser to parse features without args. GitHub page showing the diff: https://github.com/google/cld3/commit/c03368eff92acc56756df2d4cd74a01a674409ea BUG=672185 ========== to ========== Updating the CLD3 commit hash in DEPS The main changes are: 1) a retrained model with additional script-based features. GitHub page showing the diff: https://github.com/google/cld3/commit/fa5974a4d3b5e7934fcb166ff26ed6bfce68b18a 2) updating the feature spec parser to parse features without args. GitHub page showing the diff: https://github.com/google/cld3/commit/c03368eff92acc56756df2d4cd74a01a674409ea BUG=672185 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Updating the CLD3 commit hash in DEPS The main changes are: 1) a retrained model with additional script-based features. GitHub page showing the diff: https://github.com/google/cld3/commit/fa5974a4d3b5e7934fcb166ff26ed6bfce68b18a 2) updating the feature spec parser to parse features without args. GitHub page showing the diff: https://github.com/google/cld3/commit/c03368eff92acc56756df2d4cd74a01a674409ea BUG=672185 ========== to ========== Updating the CLD3 commit hash in DEPS The main changes are: 1) a retrained model with additional script-based features. GitHub page showing the diff: https://github.com/google/cld3/commit/fa5974a4d3b5e7934fcb166ff26ed6bfce68b18a 2) updating the feature spec parser to parse features without args. GitHub page showing the diff: https://github.com/google/cld3/commit/c03368eff92acc56756df2d4cd74a01a674409ea BUG=672185 Committed: https://crrev.com/3382ba03f380d3f681a84c8c8bf83bebf9ca2b7c Cr-Commit-Position: refs/heads/master@{#437081} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/3382ba03f380d3f681a84c8c8bf83bebf9ca2b7c Cr-Commit-Position: refs/heads/master@{#437081} |
