Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 2560473003: PPC: pass correct condition register to Assert (Closed)

Created:
4 years ago by JaideepBajwa
Modified:
4 years ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: pass correct condition register to Assert Since addi sets cr0, it should be passed to Assert method (default is cr7) R=joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Committed: https://crrev.com/3c9fa1aec2fa38102988933a2f769e765050460c Cr-Commit-Position: refs/heads/master@{#41539}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/builtins/ppc/builtins-ppc.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
JaideepBajwa
ptal
4 years ago (2016-12-06 22:34:58 UTC) #1
john.yan
lgtm
4 years ago (2016-12-07 00:23:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2560473003/1
4 years ago (2016-12-07 03:08:20 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-07 03:27:23 UTC) #6
commit-bot: I haz the power
4 years ago (2016-12-07 03:28:07 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3c9fa1aec2fa38102988933a2f769e765050460c
Cr-Commit-Position: refs/heads/master@{#41539}

Powered by Google App Engine
This is Rietveld 408576698