Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(797)

Issue 2560473002: [ObjC ARC] Converts ios/chrome/browser/itunes_links:unit_tests to ARC. (Closed)

Created:
4 years ago by stkhapugin
Modified:
4 years ago
CC:
chromium-reviews, pkl (ping after 24h if needed), sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ObjC ARC] Converts ios/chrome/browser/itunes_links:unit_tests to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Committed: https://crrev.com/d9ce7e82e1e3a7f32e1775d3470027fa9cc8317e Cr-Commit-Position: refs/heads/master@{#436929}

Patch Set 1 #

Patch Set 2 : git cl w #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -10 lines) Patch
M ios/chrome/browser/itunes_links/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/itunes_links/itunes_links_observer_unittest.mm View 1 2 chunks +17 lines, -10 lines 0 comments Download

Messages

Total messages: 19 (14 generated)
stkhapugin
PTAL
4 years ago (2016-12-07 10:25:43 UTC) #11
noyau (Ping after 24h)
lgtm
4 years ago (2016-12-07 12:59:46 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2560473002/20001
4 years ago (2016-12-07 13:00:07 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-07 13:04:07 UTC) #17
commit-bot: I haz the power
4 years ago (2016-12-07 13:06:48 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d9ce7e82e1e3a7f32e1775d3470027fa9cc8317e
Cr-Commit-Position: refs/heads/master@{#436929}

Powered by Google App Engine
This is Rietveld 408576698