Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2268)

Unified Diff: android_webview/browser/render_thread_manager.h

Issue 2560463002: aw: Fix race between first frame draw and view detach causing deadlock. (Closed)
Patch Set: unconditionally set has_received_frame_ to false in DeleteHardwareRendererOnUI Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « android_webview/browser/browser_view_renderer.h ('k') | android_webview/browser/render_thread_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: android_webview/browser/render_thread_manager.h
diff --git a/android_webview/browser/render_thread_manager.h b/android_webview/browser/render_thread_manager.h
index 0badea3ff9552c2b8e1b616f35a3564c468b1669..e93c4b82d85515a683b285520538ada123818cd6 100644
--- a/android_webview/browser/render_thread_manager.h
+++ b/android_webview/browser/render_thread_manager.h
@@ -100,6 +100,9 @@ class RenderThreadManager : public CompositorFrameConsumer {
CompositorFrameProducer* compositor_frame_producer_;
base::WeakPtr<RenderThreadManager> ui_thread_weak_ptr_;
base::CancelableClosure request_draw_gl_cancelable_closure_;
+ // Whether any frame has been received on the UI thread by
+ // RenderThreadManager.
+ bool has_received_frame_;
// Accessed by RT thread.
std::unique_ptr<HardwareRenderer> hardware_renderer_;
@@ -109,7 +112,6 @@ class RenderThreadManager : public CompositorFrameConsumer {
// Accessed by both UI and RT thread.
mutable base::Lock lock_;
- bool hardware_renderer_has_frame_;
gfx::Vector2d scroll_offset_;
ChildFrameQueue child_frames_;
const bool sync_on_draw_hardware_;
« no previous file with comments | « android_webview/browser/browser_view_renderer.h ('k') | android_webview/browser/render_thread_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698