Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(553)

Issue 2560453003: Revert of [ObjC ARC] Reland of Converts ios/chrome/browser/ui/autofill:autofill to ARC. (Closed)

Created:
4 years ago by rohitrao (ping after 24h)
Modified:
4 years ago
Reviewers:
stkhapugin, sdefresne
CC:
chromium-reviews, rouslan+autofill_chromium.org, sebsg+autofillwatch_chromium.org, pkl (ping after 24h if needed), jdonnelly+autofillwatch_chromium.org, mathp+autofillwatch_chromium.org, vabr+watchlistautofill_chromium.org, estade+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [ObjC ARC] Reland of Converts ios/chrome/browser/ui/autofill:autofill to ARC. (patchset #3 id:40001 of https://codereview.chromium.org/2555673003/ ) Reason for revert: Non-ARC files that include autofill_client_ios.h "cannot create __weak reference in file using manual reference counting". Original issue's description: > [ObjC ARC] Reland of Converts ios/chrome/browser/ui/autofill:autofill to ARC. > > Automatically generated ARCMigrate commit > Notable issues:None > BUG=624363 > TEST=None > Originally landed as http://crrev.com/2513003002#ps1 > > Committed: https://crrev.com/302d816fa77d64bd662c13e64e5a71352b728cfc > Cr-Commit-Position: refs/heads/master@{#436645} TBR=sdefresne@chromium.org,stkhapugin@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=624363 Committed: https://crrev.com/6809e0da7b2a28371b7455e246d70b256fa0bdbe Cr-Commit-Position: refs/heads/master@{#436690}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -10 lines) Patch
M ios/chrome/browser/ui/autofill/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M ios/chrome/browser/ui/autofill/autofill_client_ios.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/ui/autofill/autofill_client_ios.mm View 2 chunks +1 line, -4 lines 0 comments Download
M ios/chrome/browser/ui/autofill/autofill_save_card_infobar.mm View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
rohitrao (ping after 24h)
Created Revert of [ObjC ARC] Reland of Converts ios/chrome/browser/ui/autofill:autofill to ARC.
4 years ago (2016-12-06 20:20:19 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2560453003/1
4 years ago (2016-12-06 20:21:10 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-06 20:22:43 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/6809e0da7b2a28371b7455e246d70b256fa0bdbe Cr-Commit-Position: refs/heads/master@{#436690}
4 years ago (2016-12-06 20:25:47 UTC) #7
sdefresne
lgtm
4 years ago (2016-12-07 09:42:54 UTC) #8
stkhapugin
lgtm. Seems like it had fixed the bots.
4 years ago (2016-12-13 10:54:26 UTC) #9
rohitrao (ping after 24h)
4 years ago (2016-12-13 12:22:38 UTC) #10
Message was sent while issue was closed.
On 2016/12/13 10:54:26, stkhapugin wrote:
> lgtm. Seems like it had fixed the bots.

This ended up being unrelated to the failures, so it should be safe to reland.

Powered by Google App Engine
This is Rietveld 408576698