Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issue 256043005: Add rasterize_and_record_micro.fast_path_gpu_rasterization.key_silk_cases benchmark (Closed)

Created:
6 years, 7 months ago by Dominik Grewe
Modified:
6 years, 7 months ago
Reviewers:
tonyg, Sami
CC:
chromium-reviews, telemetry+watch_chromium.org
Visibility:
Public.

Description

Add rasterize_and_record_micro.fast_path_gpu_rasterization.key_silk_cases benchmark Same as rasterize_and_record_micro.fast_path.key_silk_cases but with forced GPU rasterization flags added (taken from smoothness.gpu_rasterization.*). This benchmark will eventually replace rasterize_and_record_micro.fast_path.key_silk_cases, but we need to stage that change to not break the buildbots (see bug). BUG=367678 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266796

Patch Set 1 : #

Patch Set 2 : Use silk_flags in repaint.py #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -16 lines) Patch
M tools/perf/benchmarks/rasterize_and_record_micro.py View 1 chunk +15 lines, -0 lines 0 comments Download
M tools/perf/benchmarks/repaint.py View 1 2 chunks +2 lines, -4 lines 0 comments Download
M tools/perf/benchmarks/silk_flags.py View 1 chunk +8 lines, -0 lines 0 comments Download
M tools/perf/benchmarks/smoothness.py View 3 chunks +3 lines, -12 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
Dominik Grewe
Changed the name slightly from the bug to be more consistent with the smoothness.fast_path_gpu_rasterization.* benchmarks. ...
6 years, 7 months ago (2014-04-28 10:48:31 UTC) #1
Sami
lgtm, thanks cleaning up the existing flags.
6 years, 7 months ago (2014-04-28 11:08:49 UTC) #2
tonyg
lgtm
6 years, 7 months ago (2014-04-28 14:07:00 UTC) #3
Dominik Grewe
The CQ bit was checked by dominikg@chromium.org
6 years, 7 months ago (2014-04-28 14:18:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dominikg@chromium.org/256043005/50001
6 years, 7 months ago (2014-04-28 14:18:46 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-28 15:01:22 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on chromium_presubmit
6 years, 7 months ago (2014-04-28 15:01:22 UTC) #7
Dominik Grewe
The CQ bit was checked by dominikg@chromium.org
6 years, 7 months ago (2014-04-28 15:05:41 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dominikg@chromium.org/256043005/50001
6 years, 7 months ago (2014-04-28 15:05:58 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-28 15:49:15 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on chromium_presubmit
6 years, 7 months ago (2014-04-28 15:49:15 UTC) #11
Dominik Grewe
On 2014/04/28 15:49:15, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
6 years, 7 months ago (2014-04-28 16:03:34 UTC) #12
Dominik Grewe
The CQ bit was checked by dominikg@chromium.org
6 years, 7 months ago (2014-04-29 08:50:18 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dominikg@chromium.org/256043005/50001
6 years, 7 months ago (2014-04-29 08:50:49 UTC) #14
commit-bot: I haz the power
6 years, 7 months ago (2014-04-29 09:11:47 UTC) #15
Message was sent while issue was closed.
Change committed as 266796

Powered by Google App Engine
This is Rietveld 408576698