Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Issue 2560403003: Fix SizeLabelToMinWidth() function such that no unnecessary space between warning label and Discard… (Closed)

Created:
4 years ago by Jialiu Lin
Modified:
4 years ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

Fix SizeLabelToMinWidth() function such that no unnecessary space between warning label and Discard button on download shelf. Note, this bug has been there for more than 3 years. The string change in crrev.com/2443343002 exposed this issue. The reason this bug was only reproducible on Win is because Win's font is narrower than other OSs' (a.k.a label with the same text on Win yields a smaller width) BUG=668472 Review-Url: https://codereview.chromium.org/2556573002 Cr-Commit-Position: refs/heads/master@{#437563} (cherry picked from commit 047611df69b7f337f96d4ce684d21cb69baeb0b8) Committed: https://chromium.googlesource.com/chromium/src/+/fdc8672287946320d9547ddbc9bc29d721e30459

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -23 lines) Patch
M chrome/browser/ui/views/download/download_item_view.h View 3 chunks +10 lines, -1 line 0 comments Download
M chrome/browser/ui/views/download/download_item_view.cc View 4 chunks +26 lines, -22 lines 0 comments Download
A chrome/browser/ui/views/download/download_item_view_unittest.cc View 1 chunk +41 lines, -0 lines 0 comments Download
M chrome/test/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Jialiu Lin
4 years ago (2016-12-10 19:03:18 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
fdc8672287946320d9547ddbc9bc29d721e30459.

Powered by Google App Engine
This is Rietveld 408576698