android: Remove command line args from intent bundle

content/public/android/java/src/org/chromium/content/app/ChildProcessServiceImpl.java

Index: content/public/android/java/src/org/chromium/content/app/ChildProcessServiceImpl.java
diff --git a/content/public/android/java/src/org/chromium/content/app/ChildProcessServiceImpl.java b/content/public/android/java/src/org/chromium/content/app/ChildProcessServiceImpl.java
index a3748f887a180d33217a4ef3340bec312b5e4edd..5316ab13d5938e4f87eba08f74217d12ba16c64d 100644
--- a/content/public/android/java/src/org/chromium/content/app/ChildProcessServiceImpl.java
+++ b/content/public/android/java/src/org/chromium/content/app/ChildProcessServiceImpl.java
@@ -284,8 +284,6 @@ public class ChildProcessServiceImpl {
 
     void initializeParams(Intent intent) {
         synchronized (mMainThread) {
-            mCommandLineParams =
-                    intent.getStringArrayExtra(ChildProcessConstants.EXTRA_COMMAND_LINE);
             // mLinkerParams is never used if Linker.isUsed() returns false.
             // See onCreate().
             mLinkerParams = new ChromiumLinkerParams(intent);

[Jay Civelli, 2016/12/12 17:40:28]

In the future, should we still depend on anything from the intent at all?

[boliu, 2016/12/12 17:54:02]

I dunno.. it's still ok to pass things that's fixed for the entire installation.
And if linker args fall into that category, then it's a win on start up time

[Jay Civelli, 2016/12/12 19:11:22]

Yes, but then the linker has to wait for the command line to be set iiuc. I
think it would be less error prone to always pass everything in the IPC call.
Not something you need to do there, but maybe add a TODO. When I'll refactor
this code as part of the servicification effort, I'll take a look at this.

[boliu, 2016/12/12 19:16:02]

Surely we can refactor the linker to not require command line args? which of
course is out of scope for this CL. But that's my plan if perf bots complain.

@@ -304,6 +302,7 @@ public class ChildProcessServiceImpl {
             if (mCommandLineParams == null) {
                 mCommandLineParams =
                         bundle.getStringArray(ChildProcessConstants.EXTRA_COMMAND_LINE);
+                mMainThread.notifyAll();
             }
             // We must have received the command line by now
             assert mCommandLineParams != null;