Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1030)

Issue 25604008: Fix test262 failures and x64 compile failure. (Closed)

Created:
7 years, 2 months ago by danno
Modified:
7 years, 2 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Fix test262 failures and x64 compile failure. R=jkummerow@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=17082

Patch Set 1 #

Patch Set 2 : Platform ports #

Patch Set 3 : Nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -44 lines) Patch
M src/arm/lithium-arm.cc View 1 11 chunks +4 lines, -13 lines 0 comments Download
M src/hydrogen.cc View 1 2 chunks +8 lines, -2 lines 0 comments Download
M src/hydrogen-instructions.h View 1 2 4 chunks +16 lines, -2 lines 0 comments Download
M src/ia32/lithium-ia32.cc View 12 chunks +4 lines, -13 lines 0 comments Download
M src/lithium-codegen.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/lithium-x64.cc View 1 8 chunks +4 lines, -13 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
danno
ptal
7 years, 2 months ago (2013-10-02 15:15:41 UTC) #1
Jakob Kummerow
LGTM
7 years, 2 months ago (2013-10-02 15:22:04 UTC) #2
danno
7 years, 2 months ago (2013-10-02 15:27:59 UTC) #3
Message was sent while issue was closed.
Committed patchset #3 manually as r17082.

Powered by Google App Engine
This is Rietveld 408576698