Add #!/usr/bin/env python to builddeps.py

Add #!/usr/bin/env python to builddeps.py

BUG=292397
TBR=sergeygs@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=226340

[stevenjb, 2013-10-01 23:27:38]

Committed patchset #1 manually as r226340 (presubmit successful).

[sergeygs, 2013-10-02 00:14:30]

On 2013/10/01 23:27:38, stevenjb wrote:
> Committed patchset #1 manually as r226340 (presubmit successful).

Steven,

Not lgtm. This script is not supposed to be executed (it contains a class that
checkdeps.py and graphdeps.py both extend -- those are the ones that are
executable). As such, builddeps.py doesn't have the execute bit set on it. With
the shebang you've added here, presubmit.py reports a warning "shebang used, but
execute bit is not set". In fact, it should have reported that warning just as
you were uploading this very patch.

--Sergey

[stevenjb, 2013-10-02 00:23:02]

On 2013/10/02 00:14:30, sergeygs wrote:
> On 2013/10/01 23:27:38, stevenjb wrote:
> > Committed patchset #1 manually as r226340 (presubmit successful).
> 
> Steven,
> 
> Not lgtm. This script is not supposed to be executed (it contains a class that
> checkdeps.py and graphdeps.py both extend -- those are the ones that are
> executable). As such, builddeps.py doesn't have the execute bit set on it.
With
> the shebang you've added here, presubmit.py reports a warning "shebang used,
but
> execute bit is not set". In fact, it should have reported that warning just as
> you were uploading this very patch.
> 
> --Sergey

OK, please fix correctly and ensure that
http://build.chromium.org/p/chromium.chromiumos/waterfall?builder=Linux%20Chr...
succeeds. Thanks!
(I looked for you on irc but didn't see you there; I probably should just have
reverted, sorry about any difficulty caused).

[sergeygs, 2013-10-02 19:52:13]

On 2013/10/02 00:23:02, stevenjb wrote:
> On 2013/10/02 00:14:30, sergeygs wrote:
> > On 2013/10/01 23:27:38, stevenjb wrote:
> > > Committed patchset #1 manually as r226340 (presubmit successful).
> > 
> > Steven,
> > 
> > Not lgtm. This script is not supposed to be executed (it contains a class
that
> > checkdeps.py and graphdeps.py both extend -- those are the ones that are
> > executable). As such, builddeps.py doesn't have the execute bit set on it.
> With
> > the shebang you've added here, presubmit.py reports a warning "shebang used,
> but
> > execute bit is not set". In fact, it should have reported that warning just
as
> > you were uploading this very patch.
> > 
> > --Sergey
> 
> OK, please fix correctly and ensure that
>
http://build.chromium.org/p/chromium.chromiumos/waterfall?builder=Linux%2520C...
> succeeds. Thanks!
> (I looked for you on irc but didn't see you there; I probably should just have
> reverted, sorry about any difficulty caused).

Oh, I see now: it's actually my attempt to reset the executable bit that had
failed. Sorry about that! With that in mind, this fix is LGTM. I'll commit a
proper fix separately sometime later then, it's not a high priority issue.