Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Unified Diff: third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js

Issue 2560353002: DevTools: move the GC button into the memory panel. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/profiler/module.json ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js
diff --git a/third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js b/third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js
index 61fe3f9314e7d7b23258fe557b9697d30898c70a..3b0192f32b416a2e735a247cc1eb73efa1a16742 100644
--- a/third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js
+++ b/third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js
@@ -384,11 +384,6 @@ Timeline.TimelinePanel = class extends UI.Panel {
}
this._panelToolbar.appendSeparator();
- var garbageCollectButton = new UI.ToolbarButton(Common.UIString('Collect garbage'), 'largeicon-trash-bin');
- garbageCollectButton.addEventListener('click', this._garbageCollectButtonClicked, this);
- this._panelToolbar.appendToolbarItem(garbageCollectButton);
-
- this._panelToolbar.appendSeparator();
this._cpuThrottlingCombobox = new UI.ToolbarComboBox(this._onCPUThrottlingChanged.bind(this));
this._panelToolbar.appendToolbarItem(this._createNetworkConditionsSelect());
this._panelToolbar.appendToolbarItem(this._cpuThrottlingCombobox);
@@ -424,10 +419,8 @@ Timeline.TimelinePanel = class extends UI.Panel {
hasSelection = true;
}
var predefinedRates = new Map([
- [1, Common.UIString('No CPU throttling')],
- [2, Common.UIString('2\xD7 slowdown')],
- [5, Common.UIString('5\xD7 slowdown')],
- [10, Common.UIString('10\xD7 slowdown')],
+ [1, Common.UIString('No CPU throttling')], [2, Common.UIString('2\xD7 slowdown')],
+ [5, Common.UIString('5\xD7 slowdown')], [10, Common.UIString('10\xD7 slowdown')],
[20, Common.UIString('20\xD7 slowdown')]
]);
for (var rate of predefinedRates)
@@ -639,12 +632,6 @@ Timeline.TimelinePanel = class extends UI.Panel {
this._stopRecording();
}
- _garbageCollectButtonClicked() {
- var targets = SDK.targetManager.targets();
- for (var i = 0; i < targets.length; ++i)
- targets[i].heapProfilerAgent().collectGarbage();
- }
-
_clear() {
if (Runtime.experiments.isEnabled('timelineRuleUsageRecording') && this._markUnusedCSS.get())
Components.CoverageProfile.instance().reset();
« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/profiler/module.json ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698