Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Side by Side Diff: chrome/browser/ui/cocoa/media_picker/desktop_media_picker_cocoa.mm

Issue 2560333002: Remove Deprecate Code For Desktop Capture Picker Old UI (Closed)
Patch Set: Further remove CombinedDesktopMediaList Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/cocoa/media_picker/desktop_media_picker_cocoa.h" 5 #include "chrome/browser/ui/cocoa/media_picker/desktop_media_picker_cocoa.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "base/command_line.h" 9 #include "base/command_line.h"
msw 2016/12/12 20:19:58 nit: remove
qiangchen 2016/12/12 20:41:28 Done.
10 #import "chrome/browser/ui/cocoa/media_picker/desktop_media_picker_controller_de precated.h"
11 #import "chrome/browser/ui/cocoa/media_picker/desktop_media_picker_controller.h" 10 #import "chrome/browser/ui/cocoa/media_picker/desktop_media_picker_controller.h"
12 #include "extensions/common/switches.h" 11 #include "extensions/common/switches.h"
msw 2016/12/12 20:19:59 nit: remove
qiangchen 2016/12/12 20:41:28 Done.
13 12
14 DesktopMediaPickerCocoa::DesktopMediaPickerCocoa() { 13 DesktopMediaPickerCocoa::DesktopMediaPickerCocoa() {
15 } 14 }
16 15
17 DesktopMediaPickerCocoa::~DesktopMediaPickerCocoa() { 16 DesktopMediaPickerCocoa::~DesktopMediaPickerCocoa() {
18 } 17 }
19 18
20 void DesktopMediaPickerCocoa::Show( 19 void DesktopMediaPickerCocoa::Show(
21 content::WebContents* web_contents, 20 content::WebContents* web_contents,
22 gfx::NativeWindow context, 21 gfx::NativeWindow context,
23 gfx::NativeWindow parent, 22 gfx::NativeWindow parent,
24 const base::string16& app_name, 23 const base::string16& app_name,
25 const base::string16& target_name, 24 const base::string16& target_name,
26 std::unique_ptr<DesktopMediaList> screen_list, 25 std::unique_ptr<DesktopMediaList> screen_list,
27 std::unique_ptr<DesktopMediaList> window_list, 26 std::unique_ptr<DesktopMediaList> window_list,
28 std::unique_ptr<DesktopMediaList> tab_list, 27 std::unique_ptr<DesktopMediaList> tab_list,
29 bool request_audio, 28 bool request_audio,
30 const DoneCallback& done_callback) { 29 const DoneCallback& done_callback) {
31 if (base::CommandLine::ForCurrentProcess()->HasSwitch(
32 extensions::switches::kDisableDesktopCapturePickerNewUI)) {
33 controller_deprecated_.reset([[DesktopMediaPickerControllerDeprecated alloc]
msw 2016/12/12 20:19:58 Remove this member from desktop_media_picker_cocoa
qiangchen 2016/12/12 20:41:28 Done.
34 initWithScreenList:std::move(screen_list)
35 windowList:std::move(window_list)
36 tabList:std::move(tab_list)
37 parent:parent
38 callback:done_callback
39 appName:app_name
40 targetName:target_name
41 requestAudio:request_audio]);
42 [controller_deprecated_ showWindow:nil];
43 return;
44 }
45
46 controller_.reset([[DesktopMediaPickerController alloc] 30 controller_.reset([[DesktopMediaPickerController alloc]
47 initWithScreenList:std::move(screen_list) 31 initWithScreenList:std::move(screen_list)
48 windowList:std::move(window_list) 32 windowList:std::move(window_list)
49 tabList:std::move(tab_list) 33 tabList:std::move(tab_list)
50 parent:parent 34 parent:parent
51 callback:done_callback 35 callback:done_callback
52 appName:app_name 36 appName:app_name
53 targetName:target_name 37 targetName:target_name
54 requestAudio:request_audio]); 38 requestAudio:request_audio]);
55 [controller_ showWindow:nil]; 39 [controller_ showWindow:nil];
56 } 40 }
57 41
58 // static 42 // static
59 std::unique_ptr<DesktopMediaPicker> DesktopMediaPicker::Create() { 43 std::unique_ptr<DesktopMediaPicker> DesktopMediaPicker::Create() {
60 return std::unique_ptr<DesktopMediaPicker>(new DesktopMediaPickerCocoa()); 44 return std::unique_ptr<DesktopMediaPicker>(new DesktopMediaPickerCocoa());
61 } 45 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698