Simplify how patch files are specified to analyzer.

Simplify how patch files are specified to analyzer.

After discussion with kmillikin@, sigmund@, and scheglov@, we decided
that specifying the patch files in libraries.dart is more complex (and
less flexible) than we'd like.  This CL changes things so that the
patch files are specified in analysis options using a simple map from
library name (e.g. "dart:core") to a list of patch file paths.

Clients are now allowed to put patch files wherever they want; they
don't need to be inside the sdk directory.

Note that we no longer include the patch configuration in
encodeCrossContextOptions.  This should be ok, since we don't have any
use case in which a single instance of analyzer needs to accommodate
multiple patch configurations.

R=scheglov@google.com

Committed: https://github.com/dart-lang/sdk/commit/02fe40c6f7ef4f96907ae8b49598cddfe2ce81a6

[Paul Berry, 2016-12-09 22:45:06]

paulberry@google.com changed reviewers:
+ scheglov@google.com

[scheglov, 2016-12-09 22:54:07]

lgtm

https://codereview.chromium.org/2560323002/diff/1/pkg/analyzer/lib/src/task/d...
File pkg/analyzer/lib/src/task/dart.dart (right):

https://codereview.chromium.org/2560323002/diff/1/pkg/analyzer/lib/src/task/d...
pkg/analyzer/lib/src/task/dart.dart:4067: (context.sourceFactory.dartSdk as
FolderBasedDartSdk)
Will this work for MockSdk(s)?

[Paul Berry, 2016-12-09 23:00:31]

https://codereview.chromium.org/2560323002/diff/1/pkg/analyzer/lib/src/task/d...
File pkg/analyzer/lib/src/task/dart.dart (right):

https://codereview.chromium.org/2560323002/diff/1/pkg/analyzer/lib/src/task/d...
pkg/analyzer/lib/src/task/dart.dart:4067: (context.sourceFactory.dartSdk as
FolderBasedDartSdk)
On 2016/12/09 22:54:06, scheglov wrote:
> Will this work for MockSdk(s)?

Probably not, but I think that's ok.  We only use MockSdk in unit tests that
don't need a full SDK, and I don't expect there to be any overlap between those
unit tests and unit tests that exercise patching.

[Paul Berry, 2016-12-12 18:15:23]

Description was changed from

==========
Simplify how patch files are specified to analyzer.

After discussion with kmillikin@, sigmund@, and scheglov@, we decided
that specifying the patch files in libraries.dart is more complex (and
less flexible) than we'd like.  This CL changes things so that the
patch files are specified in analysis options using a simple map from
library name (e.g. "dart:core") to a list of patch file paths.

Clients are now allowed to put patch files wherever they want; they
don't need to be inside the sdk directory.

Note that we no longer include the patch configuration in
encodeCrossContextOptions.  This should be ok, since we don't have any
use case in which a single instance of analyzer needs to accommodate
multiple patch configurations.
==========

to

==========
Simplify how patch files are specified to analyzer.

After discussion with kmillikin@, sigmund@, and scheglov@, we decided
that specifying the patch files in libraries.dart is more complex (and
less flexible) than we'd like.  This CL changes things so that the
patch files are specified in analysis options using a simple map from
library name (e.g. "dart:core") to a list of patch file paths.

Clients are now allowed to put patch files wherever they want; they
don't need to be inside the sdk directory.

Note that we no longer include the patch configuration in
encodeCrossContextOptions.  This should be ok, since we don't have any
use case in which a single instance of analyzer needs to accommodate
multiple patch configurations.

R=scheglov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/02fe40c6f7ef4f96907ae8b49598cddfe2ce81a6
==========

[Paul Berry, 2016-12-12 18:15:24]

Committed patchset #1 (id:1) manually as
02fe40c6f7ef4f96907ae8b49598cddfe2ce81a6 (presubmit successful).