|
Simplify how patch files are specified to analyzer.
After discussion with kmillikin@, sigmund@, and scheglov@, we decided
that specifying the patch files in libraries.dart is more complex (and
less flexible) than we'd like. This CL changes things so that the
patch files are specified in analysis options using a simple map from
library name (e.g. "dart:core") to a list of patch file paths.
Clients are now allowed to put patch files wherever they want; they
don't need to be inside the sdk directory.
Note that we no longer include the patch configuration in
encodeCrossContextOptions. This should be ok, since we don't have any
use case in which a single instance of analyzer needs to accommodate
multiple patch configurations.
R=scheglov@google.com
Committed: https://github.com/dart-lang/sdk/commit/02fe40c6f7ef4f96907ae8b49598cddfe2ce81a6
Total comments: 2
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+81 lines, -348 lines) |
Patch |
![](/static/closedtriangle.gif) |
M |
pkg/analysis_server/test/mock_sdk.dart
|
View
|
|
1 chunk |
+0 lines, -3 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
pkg/analyzer/lib/src/context/context.dart
|
View
|
|
3 chunks |
+17 lines, -2 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
pkg/analyzer/lib/src/dart/sdk/patch.dart
|
View
|
|
3 chunks |
+6 lines, -19 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
pkg/analyzer/lib/src/generated/engine.dart
|
View
|
|
7 chunks |
+8 lines, -10 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
pkg/analyzer/lib/src/generated/sdk.dart
|
View
|
|
9 chunks |
+0 lines, -124 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
pkg/analyzer/lib/src/task/dart.dart
|
View
|
|
2 chunks |
+12 lines, -3 lines |
2 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
pkg/analyzer/test/generated/engine_test.dart
|
View
|
|
2 chunks |
+4 lines, -2 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
pkg/analyzer/test/src/context/mock_sdk.dart
|
View
|
|
1 chunk |
+0 lines, -3 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
pkg/analyzer/test/src/dart/sdk/patch_test.dart
|
View
|
|
11 chunks |
+34 lines, -37 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
pkg/analyzer/test/src/dart/sdk/sdk_test.dart
|
View
|
|
2 chunks |
+0 lines, -145 lines |
0 comments
|
Download
|
Total messages: 6 (2 generated)
|