Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issues Search
    My Issues | Starred     Open | Closed | All

Side by Side Diff: third_party/WebKit/LayoutTests/intersection-observer/observer-attributes.html

Issue 2560253004: IntersectionObserver: convert tests to testharness.js (Closed)
Patch Set: Formatting tweaks and explicit resource paths Created 3 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« third_party/WebKit/LayoutTests/intersection-observer/multiple-targets.html ('K') | « third_party/WebKit/LayoutTests/intersection-observer/multiple-thresholds-expected.txt ('k') | third_party/WebKit/LayoutTests/intersection-observer/observer-attributes-expected.txt » ('j') | third_party/WebKit/LayoutTests/intersection-observer/observer-exceptions.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <!DOCTYPE html> 1 <!DOCTYPE html>
2 <script src="../resources/testharness.js"></script>
3 <script src="../resources/testharnessreport.js"></script>
4
2 <div id="root"></div> 5 <div id="root"></div>
3 <script src="../resources/js-test.js"></script> 6
4 <script> 7 <script>
5 description("Test for observer attribute getters."); 8 test(function() {
9 var observer = new IntersectionObserver(function(e) {}, {});
10 test(function() { assert_true(observer.root === null) },
foolip 2017/01/11 13:42:53 Suggest assert_equals(observer.root, null, "observ
szager1 2017/01/23 23:18:03 Done.
11 "observer.root === null");
12 test(function() { assert_array_equals(observer.thresholds, [0]) },
13 "observer.thresholds == [0]");
14 test(function() { assert_equals(observer.rootMargin, "0px 0px 0px 0px") },
15 "observer.rootMargin == '0px 0px 0px 0px'");
16
6 var rootDiv = document.getElementById("root"); 17 var rootDiv = document.getElementById("root");
7
8 var observer = new IntersectionObserver(function(e) {}, {});
9 shouldBeNull("observer.root");
10 shouldBe("observer.thresholds", "[0]");
11 shouldBeEqualToString("observer.rootMargin", "0px 0px 0px 0px");
12
13 observer = new IntersectionObserver(function(e) {}, { 18 observer = new IntersectionObserver(function(e) {}, {
14 root: rootDiv, 19 root: rootDiv,
15 threshold: [0, 0.25, 0.5, 1.0], 20 threshold: [0, 0.25, 0.5, 1.0],
16 rootMargin: "10% 20px" 21 rootMargin: "10% 20px"
17 }); 22 });
18 shouldBe("observer.root", "rootDiv"); 23 test(function() { assert_true(observer.root === rootDiv) },
19 shouldBe("observer.thresholds", "[0, 0.25, 0.5, 1.0]"); 24 "observer.root === rootDiv");
20 shouldBeEqualToString("observer.rootMargin", "10% 20px 10% 20px"); 25 test(function() { assert_array_equals(observer.thresholds, [0, 0.25, 0.5, 1.0] ) },
26 "observer.thresholds == [0, 0.25, 0.5, 1.0]");
27 test(function() { assert_equals(observer.rootMargin, "10% 20px 10% 20px") },
28 "observer.rootMargin == '10% 20px 10% 20px'");
29 }, "Test for observer attribute getters.");
foolip 2017/01/11 13:42:53 "Test for " not needed.
szager1 2017/01/23 23:18:04 Done.
30
21 </script> 31 </script>
OLDNEW
« third_party/WebKit/LayoutTests/intersection-observer/multiple-targets.html ('K') | « third_party/WebKit/LayoutTests/intersection-observer/multiple-thresholds-expected.txt ('k') | third_party/WebKit/LayoutTests/intersection-observer/observer-attributes-expected.txt » ('j') | third_party/WebKit/LayoutTests/intersection-observer/observer-exceptions.html » ('J')

Powered by Google App Engine
This is Rietveld 408576698