Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm_test.cc

Issue 2560233003: Make NGBlockLayoutAlgorithmTest inherit RenderingTest (Closed)
Patch Set: revert ScopedRuntimeEnabledFeatureForTest Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm_test.cc
diff --git a/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm_test.cc b/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm_test.cc
index f08222e77776f1e36d0eebc0a27536e85d8e413d..0b98fa07e7468b6298d4efadb44e089f005257e5 100644
--- a/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm_test.cc
+++ b/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm_test.cc
@@ -12,6 +12,7 @@
#include "core/layout/ng/ng_physical_box_fragment.h"
#include "core/layout/ng/ng_physical_fragment.h"
#include "core/layout/ng/ng_units.h"
+#include "core/layout/LayoutTestHelper.h"
#include "core/style/ComputedStyle.h"
#include "testing/gtest/include/gtest/gtest.h"
@@ -31,9 +32,19 @@ NGConstraintSpace* ConstructConstraintSpace(NGWritingMode writing_mode,
.ToConstraintSpace();
}
-class NGBlockLayoutAlgorithmTest : public ::testing::Test {
+typedef bool TestParamLayoutNG;
+class NGBlockLayoutAlgorithmTest
+ : public ::testing::WithParamInterface<TestParamLayoutNG>,
+ public RenderingTest {
+ public:
+ NGBlockLayoutAlgorithmTest() {}
+
protected:
- void SetUp() override { style_ = ComputedStyle::create(); }
+ void SetUp() override {
+ style_ = ComputedStyle::create();
+ RenderingTest::SetUp();
+ enableCompositing();
+ }
NGPhysicalBoxFragment* RunBlockLayoutAlgorithm(NGConstraintSpace* space,
NGBlockNode* first_child) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698