Issue 256023002: Reland of r266437: [Files.app] Use getDriveEntryProperties() to retrieve metadata

Issue 256023002: Reland of r266437: [Files.app] Use getDriveEntryProperties() to retrieve metadata (Closed)

Created:
6 years, 7 months ago by yoshiki

Modified:
6 years, 7 months ago

Reviewers:

CC:
chromium-reviews, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, yoshiki+watch_chromium.org, rginda+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Reland of r266437: [Files.app] Use getDriveEntryProperties() to retrieve metadata This is a reland of r260688, which is reverted due to last-minute rebase mistake. Previously, we used FileEntry.getMetadata() to retrieve filesystem metadata and getDriveEntryProperties() to get Drive metadata, so we need 2 calls for 1 file on Drive. With this patch, getDriveEntryProperties() returns not only Drive metadata but also filesystem metadata. It's enough to call only getDriveEntryProperties() and we can reduce a number of calls by half. BUG=345196 TEST=browser_test passes. R=asargent@chromium.org, hashimoto@chromium.org, hirono@chromium.org TBR=asargent@chromium.org, hashimoto@chromium.org, hirono@chromium.org NOTRY=True # NOTRYing for buildbots already passes (see. crrev.com/256023002) Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266795

Patch Set 1 #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+21 lines, -3 lines)			Patch
M	chrome/browser/chromeos/extensions/file_manager/private_api_drive.cc	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	chrome/common/extensions/api/file_browser_private.idl	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	ui/file_manager/file_manager/foreground/js/metadata/metadata_cache.js	View	4 chunks	+10 lines, -3 lines	0 comments	Download