Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Side by Side Diff: chrome/browser/renderer_host/render_view_host.h

Issue 256015: Stops the throbber from spinning if the user cancels a beforeunload dialog,... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 11 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/browser_browsertest.cc ('k') | chrome/browser/renderer_host/render_view_host.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2009 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_RENDERER_HOST_RENDER_VIEW_HOST_H_ 5 #ifndef CHROME_BROWSER_RENDERER_HOST_RENDER_VIEW_HOST_H_
6 #define CHROME_BROWSER_RENDERER_HOST_RENDER_VIEW_HOST_H_ 6 #define CHROME_BROWSER_RENDERER_HOST_RENDER_VIEW_HOST_H_
7 7
8 #include <string> 8 #include <string>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 607 matching lines...) Expand 10 before | Expand all | Expand 10 after
618 // We only buffer a suspended navigation message while we a pending RVH for a 618 // We only buffer a suspended navigation message while we a pending RVH for a
619 // TabContents. There will only ever be one suspended navigation, because 619 // TabContents. There will only ever be one suspended navigation, because
620 // TabContents will destroy the pending RVH and create a new one if a second 620 // TabContents will destroy the pending RVH and create a new one if a second
621 // navigation occurs. 621 // navigation occurs.
622 scoped_ptr<ViewMsg_Navigate> suspended_nav_message_; 622 scoped_ptr<ViewMsg_Navigate> suspended_nav_message_;
623 623
624 // If we were asked to RunModal, then this will hold the reply_msg that we 624 // If we were asked to RunModal, then this will hold the reply_msg that we
625 // must return to the renderer to unblock it. 625 // must return to the renderer to unblock it.
626 IPC::Message* run_modal_reply_msg_; 626 IPC::Message* run_modal_reply_msg_;
627 627
628 // Set to true when there is an active "before unload" dialog. When true,
629 // we've forced the throbber to start in Navigate, and we need to remember to
630 // turn it off in JavaScriptMessageBoxClosed if the navigation is canceled.
631 bool is_showing_before_unload_dialog_;
632
628 // Set to true when there is a pending ViewMsg_ShouldClose message pending. 633 // Set to true when there is a pending ViewMsg_ShouldClose message pending.
629 // This ensures we don't spam the renderer many times to close. When true, 634 // This ensures we don't spam the renderer many times to close. When true,
630 // the value of unload_ack_is_for_cross_site_transition_ indicates which type 635 // the value of unload_ack_is_for_cross_site_transition_ indicates which type
631 // of unload this is for. 636 // of unload this is for.
632 bool is_waiting_for_unload_ack_; 637 bool is_waiting_for_unload_ack_;
633 638
634 // Valid only when is_waiting_for_unload_ack_ is true, this tells us if the 639 // Valid only when is_waiting_for_unload_ack_ is true, this tells us if the
635 // unload request is for closing the entire tab ( = false), or only this 640 // unload request is for closing the entire tab ( = false), or only this
636 // RenderViewHost in the case of a cross-site transition ( = true). 641 // RenderViewHost in the case of a cross-site transition ( = true).
637 bool unload_ack_is_for_cross_site_transition_; 642 bool unload_ack_is_for_cross_site_transition_;
638 643
639 bool are_javascript_messages_suppressed_; 644 bool are_javascript_messages_suppressed_;
640 645
641 // True if the render view can be shut down suddenly. 646 // True if the render view can be shut down suddenly.
642 bool sudden_termination_allowed_; 647 bool sudden_termination_allowed_;
643 648
644 // DevTools triggers this mode when user chooses inspect lens tool. 649 // DevTools triggers this mode when user chooses inspect lens tool.
645 // While in this mode, mouse click is converted into InspectElement 650 // While in this mode, mouse click is converted into InspectElement
646 // command. 651 // command.
647 bool in_inspect_element_mode_; 652 bool in_inspect_element_mode_;
648 653
649 NotificationRegistrar registrar_; 654 NotificationRegistrar registrar_;
650 655
651 DISALLOW_COPY_AND_ASSIGN(RenderViewHost); 656 DISALLOW_COPY_AND_ASSIGN(RenderViewHost);
652 }; 657 };
653 658
654 #endif // CHROME_BROWSER_RENDERER_HOST_RENDER_VIEW_HOST_H_ 659 #endif // CHROME_BROWSER_RENDERER_HOST_RENDER_VIEW_HOST_H_
OLDNEW
« no previous file with comments | « chrome/browser/browser_browsertest.cc ('k') | chrome/browser/renderer_host/render_view_host.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698