third_party/WebKit/Source/devtools/front_end/network/NetworkOverview.js - Issue 2560043005: DevTools: Remove unused variables. Disallow unused variables with eslint

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/network/NetworkOverview.js

Issue 2560043005: DevTools: Remove unused variables. Disallow unused variables with eslint (Closed)

Patch Set: Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js ('k') | third_party/WebKit/Source/devtools/front_end/profiler/CPUProfileView.js » ('j') | third_party/WebKit/Source/devtools/front_end/sdk/DOMModel.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/network/NetworkOverview.js

diff --git a/third_party/WebKit/Source/devtools/front_end/network/NetworkOverview.js b/third_party/WebKit/Source/devtools/front_end/network/NetworkOverview.js

index 017d02cc886a6cfce713965fb58f8181a3bb6f33..4569a3a70afc83a27ba47a4fe1c7f0f030512ddd 100644

--- a/third_party/WebKit/Source/devtools/front_end/network/NetworkOverview.js

+++ b/third_party/WebKit/Source/devtools/front_end/network/NetworkOverview.js

@@ -175,10 +175,6 @@ Network.NetworkOverview = class extends UI.TimelineOverviewBase {

new Network.NetworkTimeBoundary(this._calculator.minimumBoundary(), this._calculator.maximumBoundary());

if (this._windowStart || this._windowEnd) {

this._restoringWindow = true;

dgozman 2016/12/10 02:15:14 Let's maybe remove more now?

einbinder 2016/12/12 20:41:18 Done.

- var startTime = this._calculator.minimumBoundary();

- var totalTime = this._calculator.boundarySpan();

dgozman 2016/12/10 02:15:14 Let's double-check for side-effects.

einbinder 2016/12/12 20:41:18 Done.

- var left = (this._windowStart - startTime) / totalTime;

- var right = (this._windowEnd - startTime) / totalTime;

this._restoringWindow = false;

}