Enable Automatic Passwords Saving

chrome/browser/password_manager/chrome_password_manager_client_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+#include "base/command_line.h"
+
 #include "chrome/browser/password_manager/chrome_password_manager_client.h"
 
 #include "chrome/test/base/chrome_render_view_host_test_harness.h"
 #include "components/password_manager/core/browser/password_manager_logger.h"
 #include "content/public/browser/browser_context.h"
 #include "content/public/browser/web_contents.h"
 #include "testing/gmock/include/gmock/gmock.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 using content::BrowserContext;
@@ skipping 54 matching lines @@
 TEST_F(ChromePasswordManagerClientTest, LogSavePasswordProgressDetachLogger) {
   ChromePasswordManagerClient* client = GetClient();
 
   client->SetLogger(&logger);
   // After detaching the logger, no text should be passed.
   client->SetLogger(NULL);
   EXPECT_CALL(logger, LogSavePasswordProgress(kTestText)).Times(0);
   client->LogSavePasswordProgress(kTestText);
   EXPECT_FALSE(client->IsLoggingActive());
 }
+
+TEST_F(ChromePasswordManagerClientTest, IsAutomaticPasswordSavingEnabledTest) {

[vabr (Chromium), 2014/04/29 09:08:26]

nit: please split this test into two: one testing the default behaviour, and the
other setting the command line flag and testing that.
Having smaller independent tests helps both to understand better a potential
failure, and also avoid flakiness.

[rchtara, 2014/04/29 12:20:08]

Done.

+  ChromePasswordManagerClient* client = GetClient();
+  EXPECT_FALSE(client->IsAutomaticPasswordSavingEnabled());
+
+  CommandLine::ForCurrentProcess()->AppendSwitch(
+      password_manager::switches::kEnableAutomaticPasswordSaving);
+
+  EXPECT_TRUE(client->IsAutomaticPasswordSavingEnabled());
+}