components/password_manager/core/common/password_manager_switches.cc - Issue 256003003: Enable Automatic Passwords Saving

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/password_manager/core/common/password_manager_switches.cc

Issue 256003003: Enable Automatic Passwords Saving (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "components/password_manager/core/common/password_manager_switches.h"	5 #include "components/password_manager/core/common/password_manager_switches.h"

6	6

7 namespace password_manager {	7 namespace password_manager {

8	8

9 namespace switches {	9 namespace switches {

10	10

	11 // Disables password prompt and saves automatically password without notifying
	vabr (Chromium) 2014/04/28 13:43:42 nit: Suggested reformulation: "Disables the save- nit: Suggested reformulation: "Disables the save-password prompt. Passwords are then saved automatically, without asking the user." (Note in particular the difference between "asking" and "notifying" the user. If we make this a user-facing feature, there will be a notification, but not a question. The suggested change will keep the flag comment up to date.) rchtara 2014/04/28 15:13:09 Done. Show quoted text On 2014/04/28 13:43:42, vabr (Chromium) wrote: > nit: Suggested reformulation: > > "Disables the save-password prompt. Passwords are then saved automatically, > without asking the user." > > (Note in particular the difference between "asking" and "notifying" the user. If > we make this a user-facing feature, there will be a notification, but not a > question. The suggested change will keep the flag comment up to date.) Done.
	12 // the user.

	13 const char kEnableAutomaticPasswordSaving[] =

	14 "enable-automatic-password-saving";

	15

11 // Enables the chrome://memory-internals/ page.	16 // Enables the chrome://memory-internals/ page.

12 const char kEnablePasswordManagerInternalsUI[] =	17 const char kEnablePasswordManagerInternalsUI[] =

13 "enable-password-manager-internals-ui";	18 "enable-password-manager-internals-ui";

14	19

15 } // namespace switches	20 } // namespace switches

16	21

17 } // namespace password_manager	22 } // namespace password_manager

OLD	NEW