Enable Automatic Passwords Saving

components/password_manager/core/browser/password_manager_client.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_PASSWORD_MANAGER_CORE_BROWSER_PASSWORD_MANAGER_CLIENT_H_
 #define COMPONENTS_PASSWORD_MANAGER_CORE_BROWSER_PASSWORD_MANAGER_CLIENT_H_
 
 #include "base/metrics/field_trial.h"
 #include "components/autofill/core/common/password_form.h"
 #include "components/autofill/core/common/password_form_fill_data.h"
 
 class PrefService;
 
 namespace password_manager {
 
 class PasswordFormManager;
 class PasswordManagerDriver;
 class PasswordStore;
 class PasswordManagerLogger;
 
 // An abstraction of operations that depend on the embedders (e.g. Chrome)
 // environment.
 class PasswordManagerClient {
  public:
   PasswordManagerClient() {}
   virtual ~PasswordManagerClient() {}
 
+  virtual bool IsAutomaticPasswordsSavingEnabled() const {

[vabr (Chromium), 2014/04/28 09:13:14]

Please document this method. For example:
"For automated testing, the save password prompt should sometimes not be shown,
and passwords immediately saved instead. That can be enforced by a command-line
flag. If auto-saving is enforced, this method returns true. The default return
value is false."

+    return false;

[vabr (Chromium), 2014/04/28 09:13:14]

nit: Please only declare the method here, and define it in the *.cc file. Inline
definitions should only be done for data member accessors (variable() and
set_variable()).

[rchtara, 2014/04/28 11:28:29]

Done.

[rchtara, 2014/04/28 11:28:29]

Done.

+  }
+
   // Informs the embedder of a password form that can be saved if the user
   // allows it. The embedder is not required to prompt the user if it decides
   // that this form doesn't need to be saved.
   virtual void PromptUserToSavePassword(PasswordFormManager* form_to_save) = 0;
 
   // Called when a password is autofilled. Default implementation is a no-op.
   virtual void PasswordWasAutofilled(
       const autofill::PasswordFormMap& best_matches) const {}
 
   // Called when password autofill is blocked by the blacklist. Default
@@ skipping 33 matching lines @@
   // displayed, and false otherwise.
   virtual bool IsLoggingActive() const;
 
  private:
   DISALLOW_COPY_AND_ASSIGN(PasswordManagerClient);
 };
 
 }  // namespace password_manager
 
 #endif  // COMPONENTS_PASSWORD_MANAGER_CORE_BROWSER_PASSWORD_MANAGER_CLIENT_H_