sdk/lib/_internal/compiler/implementation/js/template.dart - Issue 256003002: JavaScript Binary expressions not subclass of Call

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/js/template.dart

Issue 256003002: JavaScript Binary expressions not subclass of Call (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: merge Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sdk/lib/_internal/compiler/implementation/js/nodes.dart ('k') | sdk/lib/_internal/compiler/implementation/ssa/codegen.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/js/template.dart

diff --git a/sdk/lib/_internal/compiler/implementation/js/template.dart b/sdk/lib/_internal/compiler/implementation/js/template.dart

index 4d1f13db1284dd750979b7d482b7dfb651277021..f223691228fdcf25a756de57c10a41c35b985b60 100644

--- a/sdk/lib/_internal/compiler/implementation/js/template.dart

+++ b/sdk/lib/_internal/compiler/implementation/js/template.dart

@@ -458,12 +458,12 @@ class InstantiatorGeneratorVisitor implements NodeVisitor<Instantiator> {

Instantiator visitAssignment(Assignment node) {

Instantiator makeLeftHandSide = visit(node.leftHandSide);

- Instantiator makeCompoundTarget = visitNullable(node.compoundTarget);

+ String op = node.op;

Instantiator makeValue = visitNullable(node.value);

return (arguments) {

- return new Assignment._internal(

+ return new Assignment.compound(

makeLeftHandSide(arguments),

- makeCompoundTarget(arguments),

+ op,

makeValue(arguments));

};

}