Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(630)

Issue 2559983003: Add path_delimiter = "/" to layout test results JSON. (Closed)

Created:
4 years ago by qyearsley
Modified:
4 years ago
Reviewers:
jeffcarp, mithro
CC:
blink-reviews, chromium-reviews, Dirk Pranke
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add path_delimiter = "/" to layout test results JSON. Reason: the path_delimiter is different between gtest results and layout tests; in https://sites.google.com/a/chromium.org/dev/developers/the-json-test-results-format it has been suggested for some time that path_delimiter should be required. BUG=672361 Committed: https://crrev.com/26fe3e6f15dd430080d29fe1b7f0e3703e01e88e Cr-Commit-Position: refs/heads/master@{#437428}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_run_results.py View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
qyearsley
4 years ago (2016-12-08 23:05:12 UTC) #3
jeffcarp
lgtm
4 years ago (2016-12-09 00:05:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2559983003/1
4 years ago (2016-12-09 00:33:55 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-09 02:04:22 UTC) #8
commit-bot: I haz the power
4 years ago (2016-12-09 02:06:44 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/26fe3e6f15dd430080d29fe1b7f0e3703e01e88e
Cr-Commit-Position: refs/heads/master@{#437428}

Powered by Google App Engine
This is Rietveld 408576698