Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1307)

Issue 2559973003: Assert that the system clock is between 1e9 and 2e9 for Origin Trial token validation tests (Closed)

Created:
4 years ago by iclelland
Modified:
4 years ago
Reviewers:
Marc Treib
CC:
chromium-reviews, iclelland+watch_chromuim.org, jam, darin-cc_chromium.org, chasej+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Assert that the system clock is between 1e9 and 2e9 for Origin Trial token validation tests This is investigating the cause of flaky tests on the Android swarming bots. BUG=672294 TBR=treib@chromium.org Committed: https://crrev.com/1523ca526b1c0519fd5e38c6b81528164ae92033 Cr-Commit-Position: refs/heads/master@{#437266}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -0 lines) Patch
M content/common/origin_trials/trial_token_validator_unittest.cc View 2 chunks +15 lines, -0 lines 1 comment Download

Messages

Total messages: 8 (3 generated)
Marc Treib
lgtm
4 years ago (2016-12-08 16:39:29 UTC) #1
Marc Treib
https://codereview.chromium.org/2559973003/diff/1/content/common/origin_trials/trial_token_validator_unittest.cc File content/common/origin_trials/trial_token_validator_unittest.cc (right): https://codereview.chromium.org/2559973003/diff/1/content/common/origin_trials/trial_token_validator_unittest.cc#newcode105 content/common/origin_trials/trial_token_validator_unittest.cc:105: double kFutureTimestamp = 2000000000; Should probably make these const
4 years ago (2016-12-08 16:40:45 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2559973003/1
4 years ago (2016-12-08 16:41:41 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-08 17:08:22 UTC) #6
commit-bot: I haz the power
4 years ago (2016-12-08 17:11:01 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1523ca526b1c0519fd5e38c6b81528164ae92033
Cr-Commit-Position: refs/heads/master@{#437266}

Powered by Google App Engine
This is Rietveld 408576698