Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 255993002: Cleanup: Mark a function as x86-64 / ARM only. Found by clang. (Closed)

Created:
6 years, 8 months ago by Lei Zhang
Modified:
6 years, 7 months ago
Reviewers:
Mark Seaborn, hamaji
CC:
chromium-reviews, hamaji
Visibility:
Public.

Description

Cleanup: Mark a function as x86-64 / ARM only. Found by clang. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266460

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M components/nacl/loader/nonsfi/nonsfi_sandbox.cc View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
Lei Zhang
6 years, 8 months ago (2014-04-26 01:00:52 UTC) #1
Mark Seaborn
LGTM. Presumably this gives a werror on Clang 3.4?
6 years, 8 months ago (2014-04-26 01:07:00 UTC) #2
Lei Zhang
clang version 3.5.0 (trunk 206824) with -Werror
6 years, 8 months ago (2014-04-26 01:11:25 UTC) #3
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 8 months ago (2014-04-26 01:11:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/255993002/1
6 years, 8 months ago (2014-04-26 02:05:36 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-26 03:16:38 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_rel
6 years, 8 months ago (2014-04-26 03:16:39 UTC) #7
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 8 months ago (2014-04-26 03:47:46 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/255993002/1
6 years, 8 months ago (2014-04-26 03:51:37 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-26 04:44:22 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_rel
6 years, 8 months ago (2014-04-26 04:44:22 UTC) #11
hamaji
The CQ bit was checked by hamaji@chromium.org
6 years, 8 months ago (2014-04-26 05:01:37 UTC) #12
hamaji
Ah, thanks for the fix!
6 years, 8 months ago (2014-04-26 05:01:49 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/255993002/1
6 years, 8 months ago (2014-04-26 05:02:58 UTC) #14
commit-bot: I haz the power
6 years, 7 months ago (2014-04-28 07:06:47 UTC) #15
Message was sent while issue was closed.
Change committed as 266460

Powered by Google App Engine
This is Rietveld 408576698