Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Issue 2559903002: Replace CFX_ByteStringArray with std::vector. (Closed)

Created:
4 years ago by Tom Sepez
Modified:
4 years ago
Reviewers:
dsinclair
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Replace CFX_ByteStringArray with std::vector. Also convernt one nearby array to vector as well. Committed: https://pdfium.googlesource.com/pdfium/+/1306b180a6a8e306a7d00db9cdaa983784c354ed

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -25 lines) Patch
M core/fxcrt/fx_basic.h View 1 chunk +0 lines, -1 line 0 comments Download
M xfa/fgas/font/cfgas_fontmgr.h View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/fgas/font/cfgas_fontmgr.cpp View 2 chunks +17 lines, -22 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Tom Sepez
Dan, more random fun.
4 years ago (2016-12-08 00:23:14 UTC) #4
dsinclair
lgtm
4 years ago (2016-12-08 02:57:27 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2559903002/1
4 years ago (2016-12-08 02:57:31 UTC) #9
commit-bot: I haz the power
4 years ago (2016-12-08 02:57:50 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/1306b180a6a8e306a7d00db9cdaa983784c3...

Powered by Google App Engine
This is Rietveld 408576698