Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 2559893003: Allow cipd manifest file to contain package name templates. (Closed)

Created:
4 years ago by iannucci
Modified:
4 years ago
Reviewers:
dnj, Vadim Sh.
CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, maruel+w_chromium.org, tandrii+luci-go_chromium.org
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

Allow cipd ensure file to contain package name templates. This will allow ensure files to be generically specified regardless of platform, e.g. path/to/package/${platform} git_revision:deadbeef.... R=dnj@chromium.org, vadimsh@chromium.org BUG=663843 Committed: https://github.com/luci/luci-go/commit/307e15deab37650e9627fe3d06ee88a2dd82e1cd

Patch Set 1 #

Patch Set 2 : Add test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -11 lines) Patch
M cipd/client/cipd/client.go View 1 3 chunks +39 lines, -11 lines 0 comments Download
M cipd/client/cipd/client_test.go View 1 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
iannucci
4 years ago (2016-12-08 18:26:21 UTC) #1
Vadim Sh.
lgtm with nits: 1. Change "manifest file" in CL description to "ensure file". "Manifest file" ...
4 years ago (2016-12-08 21:05:55 UTC) #2
iannucci
done
4 years ago (2016-12-09 01:15:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2559893003/20001
4 years ago (2016-12-09 03:56:10 UTC) #7
commit-bot: I haz the power
4 years ago (2016-12-09 04:04:52 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://github.com/luci/luci-go/commit/307e15deab37650e9627fe3d06ee88a2dd82e1cd

Powered by Google App Engine
This is Rietveld 408576698