Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(421)

Issue 2559893002: Force GC in different ways for different measurements in blink_perf tests (Closed)

Created:
4 years ago by Xianzhu
Modified:
4 years ago
Reviewers:
pdr.
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Force GC in different ways for different measurements in blink_perf tests Previously we force GC before each iteration of test, but for frame time measurement, the result is much affected by GC performance. Now force GC in different ways: - measureTime: force GC before recording the start time of each iteration; - measureRunsPerSecond: same as above; - measureFrameTime: force GC before starting the whole test; Other measurements either call one of the above measurement methods, or don't call scheduleNextRun() which previously forced GC so not affected. BUG=667811 Committed: https://crrev.com/a61df787643d5238a3f902a2acfafc85c0e6690f Cr-Commit-Position: refs/heads/master@{#437109}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -1 line) Patch
M third_party/WebKit/PerformanceTests/resources/runner.js View 4 chunks +9 lines, -1 line 0 comments Download

Messages

Total messages: 15 (8 generated)
Xianzhu
4 years ago (2016-12-07 23:39:32 UTC) #4
pdr.
On 2016/12/07 at 23:39:32, wangxianzhu wrote: > LGTM Before landing, can you do a sanity ...
4 years ago (2016-12-08 00:04:38 UTC) #5
pdr.
On 2016/12/08 at 00:04:38, pdr. wrote: > On 2016/12/07 at 23:39:32, wangxianzhu wrote: > > ...
4 years ago (2016-12-08 00:06:04 UTC) #6
Xianzhu
On 2016/12/08 00:06:04, pdr. wrote: > On 2016/12/08 at 00:04:38, pdr. wrote: > > On ...
4 years ago (2016-12-08 00:12:01 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2559893002/1
4 years ago (2016-12-08 01:11:33 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-08 01:22:09 UTC) #13
commit-bot: I haz the power
4 years ago (2016-12-08 01:25:50 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a61df787643d5238a3f902a2acfafc85c0e6690f
Cr-Commit-Position: refs/heads/master@{#437109}

Powered by Google App Engine
This is Rietveld 408576698