Issue 2559883002: fixes #28032, await in cascade

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2559883002: fixes #28032, await in cascade (Closed)

Created:
4 years ago by Jennifer Messerly

Modified:
4 years ago

Reviewers:
vsm

CC:
dev-compiler+reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

fixes #28032, await in cascade R=vsm@google.com Committed: https://github.com/dart-lang/sdk/commit/ef4baafae56260eb77165d45e5365cdc962560b0

Patch Set 1 #

Total comments: 1

Created: 4 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -1 line)			Patch
	M	pkg/dev_compiler/lib/src/compiler/js_metalet.dart	View		2 chunks	+3 lines, -1 line	1 comment	Download
	A	pkg/dev_compiler/test/codegen/language/await_in_cascade_test.dart	View		1 chunk	+15 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Jennifer Messerly

bad short circuit logic caused us to fail to find "this" :) https://codereview.chromium.org/2559883002/diff/1/pkg/dev_compiler/lib/src/compiler/js_metalet.dart File pkg/dev_compiler/lib/src/compiler/js_metalet.dart ...

4 years ago (2016-12-07 21:57:20 UTC) #1

Jennifer Messerly

4 years ago (2016-12-07 22:00:25 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
ef4baafae56260eb77165d45e5365cdc962560b0 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages