Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issue 2559843002: move lld-incompatible linker flags inside !use_lld clause (Closed)

Created:
4 years ago by inglorion
Modified:
4 years ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

move lld-incompatible linker flags inside !use_lld clause Using is_official_build=true and use_lld=true on Windows would result in linker errors caused by /LTCG being passed to the linker. This change causes /LTCG to not be passed if use_lld is true. BUG= Committed: https://crrev.com/62b078da1000f7cbbc45a5a442a2f49288e2a6b2 Cr-Commit-Position: refs/heads/master@{#437086}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M build/config/compiler/BUILD.gn View 1 chunk +6 lines, -6 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
inglorion
Please take a look.
4 years ago (2016-12-07 20:48:00 UTC) #3
hans
lgtm (I think you need to wait for Nico as well since he's in build/OWNERS)
4 years ago (2016-12-07 20:50:54 UTC) #4
Nico
lgtm
4 years ago (2016-12-07 20:58:24 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2559843002/1
4 years ago (2016-12-07 21:09:44 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-07 22:21:24 UTC) #10
commit-bot: I haz the power
4 years ago (2016-12-07 22:24:48 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/62b078da1000f7cbbc45a5a442a2f49288e2a6b2
Cr-Commit-Position: refs/heads/master@{#437086}

Powered by Google App Engine
This is Rietveld 408576698