|
|
Chromium Code Reviews|
Created:
4 years ago by Sigurður Ásgeirsson Modified:
4 years ago CC:
chromium-reviews, vmpstr+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionEnable memory profiling in SyzyASAN builds.
This should expose any outstanding bugs without upsetting perf metrics,
as SyzyASAN builds are excluded from perf scrutiny.
BUG=644385
Committed: https://crrev.com/46cb2b79062956cce4cb142a3a07f358159d3555
Cr-Commit-Position: refs/heads/master@{#437087}
Patch Set 1 #
Messages
Total messages: 18 (9 generated)
The CQ bit was checked by siggi@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
siggi@chromium.org changed reviewers: + chrisha@chromium.org, thakis@chromium.org
Chris for SyzyASAN abuse approval, Nico for OWNERs please?
lgtm!
siggi@chromium.org changed reviewers: + sebmarchand@chromium.org
Seb FYI
lgtm wasn't there some announcement that syzygy is no more? does that not affect syzyasan?
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by siggi@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The news of Syzygy's death are greatly exaggerated :). SyzyASAN will be sticking around until we have a replacement, and even then the replacement will be using the SyzyASAN runtime, or a derivative thereof. On Wed, Dec 7, 2016, 16:31 <thakis@chromium.org> wrote: > lgtm > > wasn't there some announcement that syzygy is no more? does that not affect > syzyasan? > > https://codereview.chromium.org/2559833002/ > -- You received this message because you are subscribed to the Google Groups "Chromium-reviews" group. To unsubscribe from this group and stop receiving emails from it, send an email to chromium-reviews+unsubscribe@chromium.org.
The announcement was about the Syzygy optimization pipeline, SyzyAsan is still here (we're working on removing the SyzyAsan instrumentation and use Clang instead, but we'll probably keep the SyzyAsan runtime for a while)
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1481148072518380, "parent_rev":
"a44b98bb26c0f189bd816d869d6e37d62fd84d4e", "commit_rev":
"4ec623aeaeef487673258547ae9ab8b1bdccbb96"}
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Enable memory profiling in SyzyASAN builds. This should expose any outstanding bugs without upsetting perf metrics, as SyzyASAN builds are excluded from perf scrutiny. BUG=644385 ========== to ========== Enable memory profiling in SyzyASAN builds. This should expose any outstanding bugs without upsetting perf metrics, as SyzyASAN builds are excluded from perf scrutiny. BUG=644385 Committed: https://crrev.com/46cb2b79062956cce4cb142a3a07f358159d3555 Cr-Commit-Position: refs/heads/master@{#437087} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/46cb2b79062956cce4cb142a3a07f358159d3555 Cr-Commit-Position: refs/heads/master@{#437087} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
