Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(802)

Issue 2559833002: Enable memory profiling in SyzyASAN builds. (Closed)

Created:
4 years ago by Sigurður Ásgeirsson
Modified:
4 years ago
CC:
chromium-reviews, vmpstr+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable memory profiling in SyzyASAN builds. This should expose any outstanding bugs without upsetting perf metrics, as SyzyASAN builds are excluded from perf scrutiny. BUG=644385 Committed: https://crrev.com/46cb2b79062956cce4cb142a3a07f358159d3555 Cr-Commit-Position: refs/heads/master@{#437087}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M base/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 18 (9 generated)
Sigurður Ásgeirsson
Chris for SyzyASAN abuse approval, Nico for OWNERs please?
4 years ago (2016-12-07 20:25:59 UTC) #4
chrisha
lgtm!
4 years ago (2016-12-07 20:26:54 UTC) #5
Sigurður Ásgeirsson
Seb FYI
4 years ago (2016-12-07 20:45:44 UTC) #7
Nico
lgtm wasn't there some announcement that syzygy is no more? does that not affect syzyasan?
4 years ago (2016-12-07 21:31:42 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2559833002/1
4 years ago (2016-12-07 22:02:28 UTC) #12
Sigurður Ásgeirsson
The news of Syzygy's death are greatly exaggerated :). SyzyASAN will be sticking around until ...
4 years ago (2016-12-07 22:04:12 UTC) #13
Sébastien Marchand
The announcement was about the Syzygy optimization pipeline, SyzyAsan is still here (we're working on ...
4 years ago (2016-12-07 22:04:33 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-07 22:22:25 UTC) #16
commit-bot: I haz the power
4 years ago (2016-12-07 22:24:50 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/46cb2b79062956cce4cb142a3a07f358159d3555
Cr-Commit-Position: refs/heads/master@{#437087}

Powered by Google App Engine
This is Rietveld 408576698