Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(817)

Unified Diff: Source/core/dom/Document.cpp

Issue 255983003: Oilpan: Move all supplements of Page, Document, and WorkerClients to the managed heap. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: review comments Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/dom/Document.cpp
diff --git a/Source/core/dom/Document.cpp b/Source/core/dom/Document.cpp
index 2cef742dd1d62becb08fc8aadf007c9d11ab704c..5a1109c254f6de68de45e2071986b8db40704f26 100644
--- a/Source/core/dom/Document.cpp
+++ b/Source/core/dom/Document.cpp
@@ -5656,13 +5656,6 @@ void Document::clearWeakMembers(Visitor* visitor)
for (unsigned i = 0; i < deadNodes.size(); ++i)
didClearTouchEventHandlers(deadNodes[i]);
}
-
- EventHandlerRegistry* registry = static_cast<EventHandlerRegistry*>(DocumentSupplement::from(this, EventHandlerRegistry::supplementName()));
- // FIXME: Oilpan: This is pretty funky. The current code disables all modifications of the
- // EventHandlerRegistry when the document becomes inactive. To keep that behavior we only
- // perform weak processing of the registry when the document is active.
- if (registry && isActive())
- registry->clearWeakMembers(visitor);
}
void Document::trace(Visitor* visitor)
@@ -5670,7 +5663,7 @@ void Document::trace(Visitor* visitor)
visitor->trace(m_styleSheetList);
visitor->trace(m_visibilityObservers);
visitor->registerWeakMembers<Document, &Document::clearWeakMembers>(this);
- Supplementable<Document>::trace(visitor);
+ DocumentSupplementable::trace(visitor);
TreeScope::trace(visitor);
ContainerNode::trace(visitor);
}

Powered by Google App Engine
This is Rietveld 408576698