Source/modules/push_messaging/PushController.cpp - Issue 255983003: Oilpan: Move all supplements of Page, Document, and WorkerClients to the managed heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/push_messaging/PushController.cpp

Issue 255983003: Oilpan: Move all supplements of Page, Document, and WorkerClients to the managed heap. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: review comments Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/modules/push_messaging/PushController.h ('K') | « Source/modules/push_messaging/PushController.h ('k') | Source/modules/quota/StorageQuotaClient.h » ('j') | Source/modules/screen_orientation/ScreenOrientationController.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/push_messaging/PushController.cpp

diff --git a/Source/modules/push_messaging/PushController.cpp b/Source/modules/push_messaging/PushController.cpp

index a097074fc835e0adc50a01863975f104939a3c4f..e67829afcbcd179ca1c0edb7824c790cde84ddda 100644

--- a/Source/modules/push_messaging/PushController.cpp

+++ b/Source/modules/push_messaging/PushController.cpp

@@ -15,13 +15,9 @@ PushController::PushController(blink::WebPushClient* client)

{

}

-PushController::~PushController()

+PassOwnPtrWillBeRawPtr<PushController> PushController::create(blink::WebPushClient* client)

{

-PassOwnPtr<PushController> PushController::create(blink::WebPushClient* client)

- return adoptPtr(new PushController(client));

+ return adoptPtrWillBeNoop(new PushController(client));

}

blink::WebPushClient* PushController::clientFrom(Page* page)