Source/modules/device_orientation/DeviceMotionController.cpp - Issue 255983003: Oilpan: Move all supplements of Page, Document, and WorkerClients to the managed heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/device_orientation/DeviceMotionController.cpp

Issue 255983003: Oilpan: Move all supplements of Page, Document, and WorkerClients to the managed heap. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: review comments Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/testing/InternalSettings.h ('K') | « Source/modules/device_orientation/DeviceMotionController.h ('k') | Source/modules/device_orientation/DeviceOrientationController.h » ('j') | Source/modules/encryptedmedia/MediaKeysController.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/device_orientation/DeviceMotionController.cpp

diff --git a/Source/modules/device_orientation/DeviceMotionController.cpp b/Source/modules/device_orientation/DeviceMotionController.cpp

index d36e1983f4f4121ac381586f821816928f26cf82..85848a15df4ba1c87229050cb55ee1e16bad13c6 100644

--- a/Source/modules/device_orientation/DeviceMotionController.cpp

+++ b/Source/modules/device_orientation/DeviceMotionController.cpp

@@ -62,7 +62,7 @@ DeviceMotionController& DeviceMotionController::from(Document& document)

DeviceMotionController* controller = static_cast<DeviceMotionController*>(DocumentSupplement::from(document, supplementName()));

if (!controller) {

controller = new DeviceMotionController(document);

- DocumentSupplement::provideTo(document, supplementName(), adoptPtr(controller));

+ DocumentSupplement::provideTo(document, supplementName(), adoptPtrWillBeNoop(controller));

}

return *controller;

}