Source/core/dom/EventHandlerRegistry.h - Issue 255983003: Oilpan: Move all supplements of Page, Document, and WorkerClients to the managed heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/EventHandlerRegistry.h

Issue 255983003: Oilpan: Move all supplements of Page, Document, and WorkerClients to the managed heap. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: non-oilpan build Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/dom/Document.cpp ('K') | « Source/core/dom/DocumentSupplementable.h ('k') | Source/core/dom/EventHandlerRegistry.cpp » ('j') | Source/core/html/shadow/TextControlInnerElements.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/dom/EventHandlerRegistry.h

diff --git a/Source/core/dom/EventHandlerRegistry.h b/Source/core/dom/EventHandlerRegistry.h

index 28191b73ed06d48ff07e5a5eba026f7cfd4ea579..e010dbdaa4c1abb00bda03184b9babdf7e919e1e 100644

--- a/Source/core/dom/EventHandlerRegistry.h

+++ b/Source/core/dom/EventHandlerRegistry.h

@@ -16,7 +16,8 @@ typedef HashCountedSet<EventTarget*> EventTargetSet;

// Registry for keeping track of event handlers. Handlers can either be

// associated with an EventTarget or be "external" handlers which live outside

// the DOM (e.g., WebViewImpl).

-class EventHandlerRegistry FINAL : public DocumentSupplement {

+class EventHandlerRegistry FINAL : public NoBaseWillBeGarbageCollectedFinalized<EventHandlerRegistry>, public DocumentSupplement {

Mads Ager (chromium) 2014/04/29 14:56:09 Similarly to SpeechInput, this has weak processing

zerny-chromium 2014/04/29 15:10:36 Missed that one. Done.

+ WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(EventHandlerRegistry);

public:

virtual ~EventHandlerRegistry();