Source/modules/device_orientation/DeviceOrientationController.h - Issue 255983003: Oilpan: Move all supplements of Page, Document, and WorkerClients to the managed heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/device_orientation/DeviceOrientationController.h

Issue 255983003: Oilpan: Move all supplements of Page, Document, and WorkerClients to the managed heap. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: using namespace WebCore Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/modules/device_orientation/DeviceMotionController.cpp ('k') | Source/modules/device_orientation/DeviceOrientationController.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/device_orientation/DeviceOrientationController.h

diff --git a/Source/modules/device_orientation/DeviceOrientationController.h b/Source/modules/device_orientation/DeviceOrientationController.h

index e0d3fde024ad05416d31e1ee82e49a3b9f1184d1..7d48227418652ede15fadefee82ad422902ac4ac 100644

--- a/Source/modules/device_orientation/DeviceOrientationController.h

+++ b/Source/modules/device_orientation/DeviceOrientationController.h

@@ -36,8 +36,8 @@ namespace WebCore {

class DeviceOrientationData;

-class DeviceOrientationController FINAL : public DeviceSensorEventController, public DocumentSupplement, public DOMWindowLifecycleObserver {

+class DeviceOrientationController FINAL : public NoBaseWillBeGarbageCollectedFinalized<DeviceOrientationController>, public DeviceSensorEventController, public DocumentSupplement, public DOMWindowLifecycleObserver {

+ WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(DeviceOrientationController);

public:

virtual ~DeviceOrientationController();

@@ -53,7 +53,7 @@ public:

virtual void didRemoveEventListener(DOMWindow*, const AtomicString&) OVERRIDE;

virtual void didRemoveAllEventListeners(DOMWindow*) OVERRIDE;

- virtual void trace(Visitor*) OVERRIDE { }

+ virtual void trace(Visitor*) OVERRIDE;

private:

explicit DeviceOrientationController(Document&);

@@ -66,7 +66,7 @@ private:

virtual bool isNullEvent(Event*) OVERRIDE;

virtual Document* document() OVERRIDE;

- RefPtrWillBePersistent<DeviceOrientationData> m_overrideOrientationData;

+ RefPtrWillBeMember<DeviceOrientationData> m_overrideOrientationData;

Document& m_document;

};