Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Side by Side Diff: Source/core/xml/DocumentXPathEvaluator.h

Issue 255983003: Oilpan: Move all supplements of Page, Document, and WorkerClients to the managed heap. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: review comments Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013, Google Inc. All rights reserved. 2 * Copyright (C) 2013, Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are met: 5 * modification, are permitted provided that the following conditions are met:
6 * 6 *
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 18 matching lines...) Expand all
29 #include "core/dom/DocumentSupplementable.h" 29 #include "core/dom/DocumentSupplementable.h"
30 #include "core/xml/XPathEvaluator.h" 30 #include "core/xml/XPathEvaluator.h"
31 #include "core/xml/XPathNSResolver.h" 31 #include "core/xml/XPathNSResolver.h"
32 32
33 namespace WebCore { 33 namespace WebCore {
34 34
35 class ExceptionState; 35 class ExceptionState;
36 class XPathExpression; 36 class XPathExpression;
37 class XPathResult; 37 class XPathResult;
38 38
39 class DocumentXPathEvaluator FINAL : public DocumentSupplement { 39 class DocumentXPathEvaluator FINAL : public NoBaseWillBeGarbageCollected<Documen tXPathEvaluator>, public DocumentSupplement {
40 WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(DocumentXPathEvaluator);
40 public: 41 public:
41 virtual ~DocumentXPathEvaluator();
haraken 2014/04/30 11:18:08 You can use DECLARE_EMPTY_DESTRUCTOR_WILL_BE_REMOV
zerny-chromium 2014/04/30 11:46:53 Again, is it not best to simply remove it now?
42
43 static DocumentXPathEvaluator& from(DocumentSupplementable&); 42 static DocumentXPathEvaluator& from(DocumentSupplementable&);
44 43
45 static PassRefPtrWillBeRawPtr<XPathExpression> createExpression(DocumentSupp lementable&, 44 static PassRefPtrWillBeRawPtr<XPathExpression> createExpression(DocumentSupp lementable&,
46 const String& expression, PassRefPtrWillBeRawPtr<XPathNSResolver>, Excep tionState&); 45 const String& expression, PassRefPtrWillBeRawPtr<XPathNSResolver>, Excep tionState&);
47 static PassRefPtrWillBeRawPtr<XPathNSResolver> createNSResolver(DocumentSupp lementable&, Node* nodeResolver); 46 static PassRefPtrWillBeRawPtr<XPathNSResolver> createNSResolver(DocumentSupp lementable&, Node* nodeResolver);
48 static PassRefPtrWillBeRawPtr<XPathResult> evaluate(DocumentSupplementable&, 47 static PassRefPtrWillBeRawPtr<XPathResult> evaluate(DocumentSupplementable&,
49 const String& expression, Node* contextNode, PassRefPtrWillBeRawPtr<XPat hNSResolver>, 48 const String& expression, Node* contextNode, PassRefPtrWillBeRawPtr<XPat hNSResolver>,
50 unsigned short type, XPathResult*, ExceptionState&); 49 unsigned short type, XPathResult*, ExceptionState&);
51 50
52 virtual void trace(Visitor*) OVERRIDE { } 51 virtual void trace(Visitor*) OVERRIDE;
53 52
54 private: 53 private:
55 DocumentXPathEvaluator(); 54 DocumentXPathEvaluator();
56 55
57 static const char* supplementName() { return "DocumentXPathEvaluator"; } 56 static const char* supplementName() { return "DocumentXPathEvaluator"; }
58 57
59 RefPtrWillBePersistent<XPathEvaluator> m_xpathEvaluator; 58 RefPtrWillBeMember<XPathEvaluator> m_xpathEvaluator;
60 }; 59 };
61 60
62 } // namespace WebCore 61 } // namespace WebCore
63 62
64 #endif // DocumentXPathEvaluator_h 63 #endif // DocumentXPathEvaluator_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698