Oilpan: Move all supplements of Page, Document, and WorkerClients to the managed heap.

Source/core/loader/PrerendererClient.h

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 22 matching lines @@
 #define PrerendererClient_h
 
 #include "platform/Supplementable.h"
 
 namespace WebCore {
 
 class Document;
 class Page;
 class Prerender;
 
-class PrerendererClient : public Supplement<Page> {
+class PrerendererClient : public WillBeHeapSupplement<Page> {
 public:
-    virtual ~PrerendererClient() { }

[haraken, 2014/04/30 11:18:08]

You can use DECLARE_EMPTY_DESTRUCTOR_WILL_BE_REMOVED.

[zerny-chromium, 2014/04/30 11:46:53]

Should we not rather remove it since it is not needed in either build?

[haraken, 2014/04/30 12:02:08]

If you omit an empty destructor, the destructor is implicitly generated in
header files, which can cause #include cycles. Also we sometimes need to define
an empty, virtual destructor. For these situations, we introduced
DECLARE_EMPTY_VIRTUAL_DESTRUCTOR_WILL_BE_REMOVED.

Either way this wouldn't be a big deal. You can just remove it if it doesn't
matter :)

-
     virtual void willAddPrerender(Prerender*) = 0;
 
     static const char* supplementName();
     static PrerendererClient* from(Page*);
 
 protected:
     PrerendererClient() { }
 };
 
 void providePrerendererClientTo(Page&, PrerendererClient*);
 
 } // namespace WebCore
 
 #endif // PrerendererClient_h