Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Side by Side Diff: Source/web/ServiceWorkerGlobalScopeClientImpl.h

Issue 255983003: Oilpan: Move all supplements of Page, Document, and WorkerClients to the managed heap. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: review comments Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2014 Google Inc. All rights reserved. 2 * Copyright (C) 2014 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 22 matching lines...) Expand all
33 33
34 #include "modules/serviceworkers/ServiceWorkerGlobalScopeClient.h" 34 #include "modules/serviceworkers/ServiceWorkerGlobalScopeClient.h"
35 #include "public/platform/WebServiceWorkerClientsInfo.h" 35 #include "public/platform/WebServiceWorkerClientsInfo.h"
36 #include "wtf/OwnPtr.h" 36 #include "wtf/OwnPtr.h"
37 37
38 namespace blink { 38 namespace blink {
39 39
40 class WebServiceWorkerContextClient; 40 class WebServiceWorkerContextClient;
41 class WebURL; 41 class WebURL;
42 42
43 class ServiceWorkerGlobalScopeClientImpl FINAL : public WebCore::ServiceWorkerGl obalScopeClient { 43 class ServiceWorkerGlobalScopeClientImpl FINAL : public NoBaseWillBeGarbageColle ctedFinalized<ServiceWorkerGlobalScopeClientImpl>, public WebCore::ServiceWorker GlobalScopeClient {
haraken 2014/04/30 02:41:22 Ditto. You can make ServiceWorkerClient NoBaseWill
44 WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(ServiceWorkerGlobalScopeClientImpl);
44 public: 45 public:
45 static PassOwnPtr<WebCore::ServiceWorkerGlobalScopeClient> create(PassOwnPtr <WebServiceWorkerContextClient>); 46 static PassOwnPtrWillBeRawPtr<WebCore::ServiceWorkerGlobalScopeClient> creat e(PassOwnPtr<WebServiceWorkerContextClient>);
46 virtual ~ServiceWorkerGlobalScopeClientImpl(); 47 virtual ~ServiceWorkerGlobalScopeClientImpl();
47 48
48 virtual void getClients(WebServiceWorkerClientsCallbacks*); 49 virtual void getClients(WebServiceWorkerClientsCallbacks*);
49 virtual WebURL scope() const OVERRIDE; 50 virtual WebURL scope() const OVERRIDE;
50 51
51 virtual void didHandleActivateEvent(int eventID, WebServiceWorkerEventResult ) OVERRIDE; 52 virtual void didHandleActivateEvent(int eventID, WebServiceWorkerEventResult ) OVERRIDE;
52 virtual void didHandleInstallEvent(int installEventID, WebServiceWorkerEvent Result) OVERRIDE; 53 virtual void didHandleInstallEvent(int installEventID, WebServiceWorkerEvent Result) OVERRIDE;
53 virtual void didHandleFetchEvent(int fetchEventID, PassRefPtr<WebCore::Respo nse>) OVERRIDE; 54 virtual void didHandleFetchEvent(int fetchEventID, PassRefPtr<WebCore::Respo nse>) OVERRIDE;
54 virtual void didHandleSyncEvent(int syncEventID) OVERRIDE; 55 virtual void didHandleSyncEvent(int syncEventID) OVERRIDE;
55 56
56 virtual void trace(WebCore::Visitor*) OVERRIDE { } 57 virtual void trace(WebCore::Visitor*) OVERRIDE { }
57 58
58 private: 59 private:
59 ServiceWorkerGlobalScopeClientImpl(PassOwnPtr<WebServiceWorkerContextClient> ); 60 ServiceWorkerGlobalScopeClientImpl(PassOwnPtr<WebServiceWorkerContextClient> );
60 61
61 OwnPtr<WebServiceWorkerContextClient> m_client; 62 OwnPtr<WebServiceWorkerContextClient> m_client;
62 }; 63 };
63 64
64 } // namespace blink 65 } // namespace blink
65 66
66 #endif // ServiceWorkerGlobalScopeClientImpl_h 67 #endif // ServiceWorkerGlobalScopeClientImpl_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698