Oilpan: Move all supplements of Page, Document, and WorkerClients to the managed heap.

Source/core/testing/InternalSettings.h

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  * Copyright (C) 2013 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
@@ skipping 25 matching lines @@
 #include "wtf/text/WTFString.h"
 
 namespace WebCore {
 
 class Document;
 class ExceptionState;
 class LocalFrame;
 class Page;
 class Settings;
 
+#if ENABLE(OILPAN)
+class InternalSettings FINAL : public InternalSettingsGenerated, public HeapSupplement<Page> {
+    WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(InternalSettings);
+#else
 class InternalSettings FINAL : public InternalSettingsGenerated {
+#endif
 public:
     class Backup {
     public:
         explicit Backup(Settings*);
         void restoreTo(Settings*);
 
         bool m_originalCSSExclusionsEnabled;
         bool m_originalAuthorShadowDOMForAnyElementEnabled;
         bool m_originalStyleScoped;
         bool m_originalCSP;
@@ skipping 10 matching lines @@
         bool m_originalCompositorDrivenAcceleratedScrollEnabled;
         bool m_originalLayerSquashingEnabled;
         bool m_originalPasswordGenerationDecorationEnabled;
     };
 
     static PassRefPtrWillBeRawPtr<InternalSettings> create(Page& page)
     {
         return adoptRefWillBeNoop(new InternalSettings(page));
     }
     static InternalSettings* from(Page&);
+
+#if !ENABLE(OILPAN)
     void hostDestroyed() { m_page = 0; }
+#endif

[haraken, 2014/04/30 02:41:22]

Just I'm curious but why do we need to clear m_page in non-oilpan builds? Given
that the InternalSettings is a supplement object of a Page, the InternalSettings
and the Page should die together in non-oilpan. If so, we won't need to clear
m_page in non-oilpan as well.

[zerny-chromium, 2014/04/30 08:29:34]

InternalSettings is RefCounted and does not keep the page alive, so it can
outlive the page. Thus m_page needs to be a WeakMember in the oilpan build.
Thanks for noticing the discrepancy!

 
     virtual ~InternalSettings();
     void resetToConsistentState();
 
     void setStandardFontFamily(const AtomicString& family, const String& script, ExceptionState&);
     void setSerifFontFamily(const AtomicString& family, const String& script, ExceptionState&);
     void setSansSerifFontFamily(const AtomicString& family, const String& script, ExceptionState&);
     void setFixedFontFamily(const AtomicString& family, const String& script, ExceptionState&);
     void setCursiveFontFamily(const AtomicString& family, const String& script, ExceptionState&);
     void setFantasyFontFamily(const AtomicString& family, const String& script, ExceptionState&);
@@ skipping 37 matching lines @@
     Page* page() const { return m_page; }
     static const char* supplementName();
 
     Page* m_page;
     Backup m_backup;
 };
 
 } // namespace WebCore
 
 #endif