Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 255983002: Cleanup: Mark conflict UI resources as Windows-only. (Closed)

Created:
6 years, 8 months ago by Lei Zhang
Modified:
6 years, 7 months ago
Reviewers:
Finnur
CC:
chromium-reviews
Visibility:
Public.

Description

Cleanup: Mark conflict UI resources as Windows-only. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266434

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -89 lines) Patch
M chrome/app/chromium_strings.grd View 1 chunk +11 lines, -9 lines 0 comments Download
M chrome/app/generated_resources.grd View 1 chunk +73 lines, -71 lines 0 comments Download
M chrome/app/google_chrome_strings.grd View 1 chunk +11 lines, -9 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Lei Zhang
6 years, 8 months ago (2014-04-25 21:28:44 UTC) #1
Finnur
LGTM
6 years, 8 months ago (2014-04-26 09:37:30 UTC) #2
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 8 months ago (2014-04-26 16:49:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/255983002/1
6 years, 8 months ago (2014-04-26 16:49:30 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-26 17:40:16 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on chromium_presubmit
6 years, 8 months ago (2014-04-26 17:40:16 UTC) #6
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 8 months ago (2014-04-26 22:09:00 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/255983002/1
6 years, 8 months ago (2014-04-26 22:10:05 UTC) #8
commit-bot: I haz the power
6 years, 7 months ago (2014-04-28 05:54:46 UTC) #9
Message was sent while issue was closed. 
Change committed as 266434

Powered by Google App Engine
This is Rietveld 408576698