Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2361)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/tab/TabWebContentsObserver.java

Issue 2559823004: Android: Clean up histogram buckets range (Closed)
Patch Set: Add comments. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/tab/TabWebContentsObserver.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/tab/TabWebContentsObserver.java b/chrome/android/java/src/org/chromium/chrome/browser/tab/TabWebContentsObserver.java
index a605938395235b736b060c9edee33bbce873865a..7fe6078f54e75e97ce5d998d8e3010b3929a6dc6 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/tab/TabWebContentsObserver.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/tab/TabWebContentsObserver.java
@@ -200,17 +200,18 @@ public class TabWebContentsObserver extends WebContentsObserver {
public void didCommitProvisionalLoadForFrame(long frameId, boolean isMainFrame, String url,
int transitionType) {
if (isMainFrame && UmaUtils.isRunningApplicationStart()) {
- // Currently it takes about 2000ms to commit a navigation if the measurement
- // begins very early in the browser start. How many buckets (b) are needed to
- // explore the _typical_ values with granularity 100ms and a maximum duration
- // of 1 minute?
- // s^{n+1} / s^{n} = 2100 / 2000
- // s = 1.05
- // s^b = 60000
- // b = ln(60000) / ln(1.05) ~= 225
- RecordHistogram.recordCustomTimesHistogram("Startup.FirstCommitNavigationTime2",
+ // Current median is 550ms, and long tail is very long. ZoomedIn gives good view of the
+ // median and ZoomedOut gives a good overview.
+ RecordHistogram.recordCustomTimesHistogram(
+ "Startup.FirstCommitNavigationTime2.ZoomedIn",
SystemClock.uptimeMillis() - UmaUtils.getForegroundStartTime(),
- 1, 60000 /* 1 minute */, TimeUnit.MILLISECONDS, 225);
+ 200, 1000, TimeUnit.MILLISECONDS, 100);
+ // For ZoomedOut very rarely is it under 50ms and this range matches
+ // CustomTabs.IntentToFirstCommitNavigationTime2.ZoomedOut.
+ RecordHistogram.recordCustomTimesHistogram(
+ "Startup.FirstCommitNavigationTime2.ZoomedOut",
+ SystemClock.uptimeMillis() - UmaUtils.getForegroundStartTime(),
+ 50, TimeUnit.MINUTES.toMillis(10), TimeUnit.MILLISECONDS, 50);
UmaUtils.setRunningApplicationStart(false);
}
« no previous file with comments | « no previous file | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698