Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1589)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/tab/TabWebContentsObserver.java

Issue 2559823004: Android: Clean up histogram buckets range (Closed)
Patch Set: Use zoomedIn and zoomedOut. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/tab/TabWebContentsObserver.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/tab/TabWebContentsObserver.java b/chrome/android/java/src/org/chromium/chrome/browser/tab/TabWebContentsObserver.java
index a605938395235b736b060c9edee33bbce873865a..89f2dfa71391fb6903fd6a6f261d935be3e736b1 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/tab/TabWebContentsObserver.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/tab/TabWebContentsObserver.java
@@ -200,17 +200,16 @@ public class TabWebContentsObserver extends WebContentsObserver {
public void didCommitProvisionalLoadForFrame(long frameId, boolean isMainFrame, String url,
int transitionType) {
if (isMainFrame && UmaUtils.isRunningApplicationStart()) {
- // Currently it takes about 2000ms to commit a navigation if the measurement
- // begins very early in the browser start. How many buckets (b) are needed to
- // explore the _typical_ values with granularity 100ms and a maximum duration
- // of 1 minute?
- // s^{n+1} / s^{n} = 2100 / 2000
- // s = 1.05
- // s^b = 60000
- // b = ln(60000) / ln(1.05) ~= 225
- RecordHistogram.recordCustomTimesHistogram("Startup.FirstCommitNavigationTime2",
+ // Current median is 550ms, and long tail is very long. ZoomedIn gives good view of the
pasko 2016/12/15 13:36:19 wow, I did not realize that so drastically! yay!
Peter Wen 2016/12/15 13:39:11 Yay! I didn't have context to know whether that wa
+ // median and ZoomedOut gives a good overview.
+ RecordHistogram.recordCustomTimesHistogram(
+ "Startup.FirstCommitNavigationTime2.ZoomedIn",
SystemClock.uptimeMillis() - UmaUtils.getForegroundStartTime(),
- 1, 60000 /* 1 minute */, TimeUnit.MILLISECONDS, 225);
+ 200, 1000, TimeUnit.MILLISECONDS, 100);
+ RecordHistogram.recordCustomTimesHistogram(
+ "Startup.FirstCommitNavigationTime2.ZoomedOut",
+ SystemClock.uptimeMillis() - UmaUtils.getForegroundStartTime(),
+ 50, TimeUnit.MINUTES.toMillis(10), TimeUnit.MILLISECONDS, 50);
Alexei Svitkine (slow) 2016/12/15 00:34:37 Is the 50 for the min value intentional? If so, ad
pasko 2016/12/15 13:36:19 I think the comment just above sufficiently explai
Peter Wen 2016/12/15 13:39:11 Done adding a quick comment and reference to other
UmaUtils.setRunningApplicationStart(false);
}
« no previous file with comments | « no previous file | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698