Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Side by Side Diff: chrome/browser/ui/views/external_protocol_dialog.h

Issue 2559783003: Don't treat Esc like Cancel in the external protocol dialog on Views. (Closed)
Patch Set: Add comment Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/views/external_protocol_dialog.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_VIEWS_EXTERNAL_PROTOCOL_DIALOG_H_ 5 #ifndef CHROME_BROWSER_UI_VIEWS_EXTERNAL_PROTOCOL_DIALOG_H_
6 #define CHROME_BROWSER_UI_VIEWS_EXTERNAL_PROTOCOL_DIALOG_H_ 6 #define CHROME_BROWSER_UI_VIEWS_EXTERNAL_PROTOCOL_DIALOG_H_
7 7
8 #include "base/compiler_specific.h" 8 #include "base/compiler_specific.h"
9 #include "base/macros.h" 9 #include "base/macros.h"
10 #include "base/time/time.h" 10 #include "base/time/time.h"
(...skipping 15 matching lines...) Expand all
26 26
27 ~ExternalProtocolDialog() override; 27 ~ExternalProtocolDialog() override;
28 28
29 // views::DialogDelegate methods: 29 // views::DialogDelegate methods:
30 int GetDefaultDialogButton() const override; 30 int GetDefaultDialogButton() const override;
31 base::string16 GetDialogButtonLabel(ui::DialogButton button) const override; 31 base::string16 GetDialogButtonLabel(ui::DialogButton button) const override;
32 base::string16 GetWindowTitle() const override; 32 base::string16 GetWindowTitle() const override;
33 void DeleteDelegate() override; 33 void DeleteDelegate() override;
34 bool Cancel() override; 34 bool Cancel() override;
35 bool Accept() override; 35 bool Accept() override;
36 bool Close() override;
36 views::View* GetContentsView() override; 37 views::View* GetContentsView() override;
37 views::Widget* GetWidget() override; 38 views::Widget* GetWidget() override;
38 const views::Widget* GetWidget() const override; 39 const views::Widget* GetWidget() const override;
39 ui::ModalType GetModalType() const override; 40 ui::ModalType GetModalType() const override;
40 41
41 private: 42 private:
42 const std::unique_ptr<const ProtocolDialogDelegate> delegate_; 43 const std::unique_ptr<const ProtocolDialogDelegate> delegate_;
43 44
44 // The message box view whose commands we handle. 45 // The message box view whose commands we handle.
45 views::MessageBoxView* message_box_view_; 46 views::MessageBoxView* message_box_view_;
46 47
47 // IDs of the associated WebContents. 48 // IDs of the associated WebContents.
48 int render_process_host_id_; 49 int render_process_host_id_;
49 int routing_id_; 50 int routing_id_;
50 51
51 // The time at which this dialog was created. 52 // The time at which this dialog was created.
52 base::TimeTicks creation_time_; 53 base::TimeTicks creation_time_;
53 54
54 DISALLOW_COPY_AND_ASSIGN(ExternalProtocolDialog); 55 DISALLOW_COPY_AND_ASSIGN(ExternalProtocolDialog);
55 }; 56 };
56 57
57 #endif // CHROME_BROWSER_UI_VIEWS_EXTERNAL_PROTOCOL_DIALOG_H_ 58 #endif // CHROME_BROWSER_UI_VIEWS_EXTERNAL_PROTOCOL_DIALOG_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/ui/views/external_protocol_dialog.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698