Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2559773002: Reapply "Move the linter core to the analyzer package" (Closed)

Created:
4 years ago by Brian Wilkerson
Modified:
4 years ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Reapply "Move the linter core to the analyzer package" R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/20baedc660d51a5e810934933f0cbfde73776c53

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1798 lines, -8 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/context_manager.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M pkg/analysis_server/lib/src/server/driver.dart View 2 chunks +2 lines, -0 lines 0 comments Download
M pkg/analysis_server/lib/src/services/linter/linter.dart View 2 chunks +3 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/analysis/notification_analysis_options_test.dart View 2 chunks +2 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/analysis/notification_errors_test.dart View 2 chunks +3 lines, -1 line 0 comments Download
M pkg/analysis_server/test/context_manager_test.dart View 2 chunks +3 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/services/linter/linter_test.dart View 2 chunks +2 lines, -0 lines 0 comments Download
A pkg/analyzer/lib/src/lint/analysis.dart View 1 chunk +262 lines, -0 lines 0 comments Download
A pkg/analyzer/lib/src/lint/config.dart View 1 chunk +243 lines, -0 lines 0 comments Download
A pkg/analyzer/lib/src/lint/io.dart View 1 chunk +68 lines, -0 lines 0 comments Download
A pkg/analyzer/lib/src/lint/linter.dart View 1 chunk +429 lines, -0 lines 0 comments Download
A pkg/analyzer/lib/src/lint/project.dart View 1 chunk +129 lines, -0 lines 0 comments Download
A pkg/analyzer/lib/src/lint/pub.dart View 1 chunk +430 lines, -0 lines 0 comments Download
A pkg/analyzer/lib/src/lint/registry.dart View 1 chunk +42 lines, -0 lines 0 comments Download
A pkg/analyzer/lib/src/lint/util.dart View 1 chunk +172 lines, -0 lines 0 comments Download
M pkg/analyzer_cli/lib/src/driver.dart View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
This is identical to what you reviewed yesterday except for the changes to pkg/analysis_server/test/analysis/notification_errors_test.dart, which ...
4 years ago (2016-12-07 17:46:09 UTC) #2
scheglov
LGTM
4 years ago (2016-12-07 17:55:31 UTC) #3
Brian Wilkerson
4 years ago (2016-12-07 17:57:23 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
20baedc660d51a5e810934933f0cbfde73776c53 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698