Refcount IFGAS_ streams all the time, too

xfa/fgas/font/cfgas_gefont.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "xfa/fgas/font/cfgas_gefont.h"
 
 #include <memory>
 #include <utility>
@@ skipping 54 matching lines @@
                                      CFGAS_FontMgr* pFontMgr) {
   CFGAS_GEFont* pFont = new CFGAS_GEFont(pFontMgr);
   if (!pFont->LoadFontInternal(pBuffer, iLength)) {
     pFont->Release();
     return nullptr;
   }
   return pFont;
 }
 
 // static
-CFGAS_GEFont* CFGAS_GEFont::LoadFont(IFGAS_Stream* pFontStream,
-                                     CFGAS_FontMgr* pFontMgr,
-                                     bool bSaveStream) {
+CFGAS_GEFont* CFGAS_GEFont::LoadFont(
+    const CFX_RetainPtr<IFGAS_Stream>& pFontStream,
+    CFGAS_FontMgr* pFontMgr,
+    bool bSaveStream) {
   CFGAS_GEFont* pFont = new CFGAS_GEFont(pFontMgr);
   if (!pFont->LoadFontInternal(pFontStream, bSaveStream)) {
     pFont->Release();
     return nullptr;
   }
   return pFont;
 }
 #endif  // _FXM_PLATFORM_ == _FXM_PLATFORM_WINDOWS_
 
 CFGAS_GEFont::CFGAS_GEFont(CFGAS_FontMgr* pFontMgr)
@@ skipping 108 matching lines @@
 bool CFGAS_GEFont::LoadFontInternal(const uint8_t* pBuffer, int32_t length) {
   if (m_pFont)
     return false;
 
   m_pFont = new CFX_Font;
   if (!m_pFont->LoadEmbedded(pBuffer, length))
     return false;
   return InitFont();
 }
 
-bool CFGAS_GEFont::LoadFontInternal(IFGAS_Stream* pFontStream,
-                                    bool bSaveStream) {
+bool CFGAS_GEFont::LoadFontInternal(
+    const CFX_RetainPtr<IFGAS_Stream>& pFontStream,
+    bool bSaveStream) {
   if (m_pFont || m_pFileRead || !pFontStream || pFontStream->GetLength() < 1)
     return false;
   if (bSaveStream)
-    m_pStream.reset(pFontStream);
+    m_pStream = pFontStream;
 
   m_pFileRead = pFontStream->MakeSeekableReadStream();
   m_pFont = new CFX_Font;
   if (!m_pFont->LoadFile(m_pFileRead)) {
     m_pFileRead.Reset();
     return false;
   }
   return InitFont();
 }
 #endif  // _FXM_PLATFORM_ == _FXM_PLATFORM_WINDOWS_
@@ skipping 232 matching lines @@
 
 int32_t CFGAS_GEFont::GetDescent() const {
   return m_pFont->GetDescent();
 }
 
 CFGAS_GEFont* CFGAS_GEFont::GetSubstFont(int32_t iGlyphIndex) const {
   iGlyphIndex = static_cast<uint32_t>(iGlyphIndex) >> 24;
   return iGlyphIndex == 0 ? const_cast<CFGAS_GEFont*>(this)
                           : m_SubstFonts[iGlyphIndex - 1];
 }