Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(829)

Issue 2559713003: Remove non-chromeos support from src/ash BUILD.gn files (Closed)

Created:
4 years ago by James Cook
Modified:
4 years ago
Reviewers:
sky
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove non-chromeos support from src/ash BUILD.gn files Ash only ships on Chrome OS, so simplify our BUILD.gn files by removing all the is_win and is_chromeos conditionals. TODO: ash/resources/BUILD.gn. Right now chrome/browser/ui has a dependency on ash resources for aura builds on all platforms. BUG=666776 TEST=bots Committed: https://crrev.com/19296fdd4d9f60b86c38b98bc926b10dc9571947 Cr-Commit-Position: refs/heads/master@{#437408}

Patch Set 1 #

Patch Set 2 : rebase #

Total comments: 1

Patch Set 3 : rebase, nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -210 lines) Patch
M ash/BUILD.gn View 1 2 14 chunks +52 lines, -136 lines 0 comments Download
M ash/common/BUILD.gn View 2 chunks +6 lines, -11 lines 0 comments Download
M ash/common/strings/BUILD.gn View 2 chunks +6 lines, -11 lines 0 comments Download
M ash/mus/BUILD.gn View 1 2 6 chunks +14 lines, -32 lines 0 comments Download
M ash/test/BUILD.gn View 5 chunks +9 lines, -20 lines 0 comments Download

Messages

Total messages: 18 (13 generated)
James Cook
sky, please take a look.
4 years ago (2016-12-08 18:07:58 UTC) #10
sky
LGTM https://codereview.chromium.org/2559713003/diff/20001/ash/BUILD.gn File ash/BUILD.gn (right): https://codereview.chromium.org/2559713003/diff/20001/ash/BUILD.gn#newcode1357 ash/BUILD.gn:1357: "//net:net", optional: //net
4 years ago (2016-12-08 20:15:06 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2559713003/40001
4 years ago (2016-12-08 20:51:15 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years ago (2016-12-09 01:24:22 UTC) #16
commit-bot: I haz the power
4 years ago (2016-12-09 01:26:15 UTC) #18
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/19296fdd4d9f60b86c38b98bc926b10dc9571947
Cr-Commit-Position: refs/heads/master@{#437408}

Powered by Google App Engine
This is Rietveld 408576698